Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2225343002: Navigation: move RestoreType and ReloadType into a separate file (Closed)

Created:
4 years, 4 months ago by Takashi Toyoshima
Modified:
4 years, 3 months ago
Reviewers:
Charlie Reis, sky, Torne
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Navigation: move RestoreType and ReloadType into a separate file To avoid circular dependency between NavigationController and NavigationEntry, move RestoreType and ReloadType into a separate file. This is a refactoring sub-change from crrev.com/2174293002. BUG=612701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=sky@chromium.org, torne@chromium.org Committed: https://crrev.com/0df1d3a01bed974dfa51c3375781f155aed7feea Cr-Commit-Position: refs/heads/master@{#417545}

Patch Set 1 #

Patch Set 2 : RestoreType #

Patch Set 3 : NavigationType #

Patch Set 4 : ReloadType #

Patch Set 5 : build fixes for Android and CrOS #

Patch Set 6 : rebase+ #

Total comments: 8

Patch Set 7 : [rebase] #

Patch Set 8 : review #27 #

Patch Set 9 : trybots ran with PS8, but one more safe change is added here #

Total comments: 8

Patch Set 10 : review #32 #

Patch Set 11 : [rebase] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2375 lines, -277 lines) Patch
M android_webview/browser/icon_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/icon_helper.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/state_serializer.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/tab_state.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/infobars/infobar_service.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor_tab_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/predictor_tab_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_android.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/tab_model/android_live_tab_context.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore.cc View 1 2 3 4 5 6 7 8 9 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 2 3 4 5 6 7 8 9 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M components/favicon/content/content_favicon_driver.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M components/favicon/content/content_favicon_driver.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/android/web_contents_observer_proxy.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 3 4 5 6 7 8 9 10 12 chunks +30 lines, -45 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +10 lines, -17 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +1 line, -14 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator.h View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigator.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigator_delegate.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 4 5 6 7 11 chunks +32 lines, -39 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
A content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2124 lines, -0 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 2 3 4 5 6 7 3 chunks +1 line, -22 lines 0 comments Download
A content/public/browser/reload_type.h View 1 2 3 4 5 6 7 8 9 1 chunk +24 lines, -0 lines 0 comments Download
A content/public/browser/restore_type.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 54 (42 generated)
Takashi Toyoshima
This CL was split from https://codereview.chromium.org/2174293002/ Can you take a look?
4 years, 4 months ago (2016-08-09 11:50:09 UTC) #14
Takashi Toyoshima
I'm still fixing uncaught caller side code for some platforms, but I think we can ...
4 years, 4 months ago (2016-08-10 03:14:15 UTC) #19
Charlie Reis
On 2016/08/10 03:14:15, toyoshim wrote: > I'm still fixing uncaught caller side code for some ...
4 years, 4 months ago (2016-08-10 05:06:35 UTC) #26
Charlie Reis
Seems reasonable on the whole. I've only looked through the content/ files so far (given ...
4 years, 4 months ago (2016-08-11 23:58:42 UTC) #27
Takashi Toyoshima
> but hopefully the rest are just mechanical? Yes, changes in chrome and android_webview are ...
4 years, 3 months ago (2016-09-07 12:07:45 UTC) #31
Charlie Reis
Thanks. I think this turned out quite nice, and will be an improvement whether we ...
4 years, 3 months ago (2016-09-09 05:41:05 UTC) #32
Takashi Toyoshima
https://codereview.chromium.org/2225343002/diff/160001/android_webview/browser/icon_helper.h File android_webview/browser/icon_helper.h (right): https://codereview.chromium.org/2225343002/diff/160001/android_webview/browser/icon_helper.h#newcode14 android_webview/browser/icon_helper.h:14: #include "content/public/browser/web_contents_observer.h" On 2016/09/09 05:41:05, Charlie Reis (slow) wrote: ...
4 years, 3 months ago (2016-09-09 07:31:30 UTC) #34
Takashi Toyoshima
TBR=sky for caller side mechanical changes
4 years, 3 months ago (2016-09-09 07:32:14 UTC) #37
Takashi Toyoshima
On 2016/09/09 07:32:14, toyoshim wrote: > TBR=sky for caller side mechanical changes and torne for ...
4 years, 3 months ago (2016-09-09 07:33:40 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225343002/200001
4 years, 3 months ago (2016-09-09 09:47:37 UTC) #50
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 3 months ago (2016-09-09 09:53:08 UTC) #52
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 09:54:55 UTC) #54
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/0df1d3a01bed974dfa51c3375781f155aed7feea
Cr-Commit-Position: refs/heads/master@{#417545}

Powered by Google App Engine
This is Rietveld 408576698