Navigation: move RestoreType and ReloadType into a separate file

content/browser/frame_host/navigation_controller_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/navigation_controller_delegate.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/ssl/ssl_manager.h"
 #include "content/public/browser/navigation_controller.h"
-#include "content/public/browser/navigation_type.h"

[Charlie Reis, 2016/08/11 23:58:43]

Why is this removed?  This file uses NavigationType, etc, so it needs the
include (per IWYU).

[Takashi Toyoshima, 2016/09/07 12:07:44]

Because when I made this change, NavigationController's interface depended on
navigation_types.h (for the interface virtual void Restore(...)) and it's clear
that navigation_controller.h included navigation_types.h internally.

Some modules in chrome encourage to reduce unnecessary include lines that should
be indirectly included, and the others do not. I'm actually not sure which
policy should be applied here.

Also, in the new CL, RestoreType and NavigationType is defined in separate file,
and will need explicit include here.

 
 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
 
 namespace content {
 class FrameTreeNode;
 class RenderFrameHostImpl;
 class NavigationEntryScreenshotManager;
 class SiteInstance;
 struct LoadCommittedDetails;
 
@@ skipping 413 matching lines @@
   TimeSmoother time_smoother_;
 
   std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_