Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index 9400fe3b69cba9cda6952fa0b2744d6668456067..b9eb8c73978ded237d477e558103f4ebd9c34792 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -301,16 +301,22 @@ ScopedJavaLocalRef<jobject> OfflinePageBridge::GetPageByOfflineId(
return ToJavaOfflinePageItem(env, *offline_page);
}
-ScopedJavaLocalRef<jobject> OfflinePageBridge::GetBestPageForOnlineURL(
+void OfflinePageBridge::SelectPageForOnlineUrl(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
- const JavaParamRef<jstring>& online_url) {
- const OfflinePageItem* offline_page =
- offline_page_model_->MaybeGetBestPageForOnlineURL(
- GURL(ConvertJavaStringToUTF8(env, online_url)));
- if (!offline_page)
- return ScopedJavaLocalRef<jobject>();
- return ToJavaOfflinePageItem(env, *offline_page);
+ const JavaParamRef<jstring>& j_online_url,
+ int tab_id,
+ const JavaParamRef<jobject>& j_callback_obj) {
+ DCHECK(j_callback_obj);
+
+ ScopedJavaGlobalRef<jobject> j_callback_ref;
+ j_callback_ref.Reset(env, j_callback_obj);
+
+ OfflinePageUtils::SelectPageForOnlineURL(
+ browser_context_,
+ GURL(ConvertJavaStringToUTF8(env, j_online_url)),
+ tab_id,
+ base::Bind(&SingleOfflinePageItemCallback, j_callback_ref));
}
void OfflinePageBridge::GetPageByOfflineUrl(

Powered by Google App Engine
This is Rietveld 408576698