Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2224923003: [interpreter] Add ability to preserve bytecode. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add ability to preserve bytecode. This adds the --ignition-preserve-bytecode flag which will preserve any existing bytecode, even if a tier-up to baseline code is performed. This is preparatory work in order to allow mixed stacks where bytecode and baseline code can be active at the same time. It also adds a {HasBaselineCode} predicate symmetric to the existing {HasBytecodeArray} predicate. Both predicates are independent and any combination of answers is valid. Further adaptation of the rest of the runtime will be done step-wise in follow-up changes. R=yangguo@chromium.org BUG=v8:5265 Committed: https://crrev.com/9e60db1f38d7f36f7697bd451307f68846dcf9f0 Cr-Commit-Position: refs/heads/master@{#38540}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Add new predicate. #

Patch Set 4 : Disable flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/compiler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-10 11:35:22 UTC) #8
Yang
lgtm
4 years, 4 months ago (2016-08-10 13:50:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224923003/60001
4 years, 4 months ago (2016-08-10 13:51:54 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-10 13:53:50 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 13:54:18 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e60db1f38d7f36f7697bd451307f68846dcf9f0
Cr-Commit-Position: refs/heads/master@{#38540}

Powered by Google App Engine
This is Rietveld 408576698