Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2233863002: [generators] Add asserts preventing mixed functions. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-preserve-bytecode-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Add asserts preventing mixed functions. This adds assertions to generator support functions that distinguish between old-style and new-style generators which make sure only one of those styles is actually used. Even though normal functions can soon be mixed (bytecode and baseline code at the same time), generator functions are still exclusively in only one tier. R=neis@chromium.org BUG=v8:5265 Committed: https://crrev.com/417b3010b2c20b68116113f03793edfa3f204520 Cr-Commit-Position: refs/heads/master@{#38541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/objects.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-10 13:39:27 UTC) #1
neis
lgtm
4 years, 4 months ago (2016-08-10 13:41:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233863002/1
4 years, 4 months ago (2016-08-10 14:18:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:19:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:20:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/417b3010b2c20b68116113f03793edfa3f204520
Cr-Commit-Position: refs/heads/master@{#38541}

Powered by Google App Engine
This is Rietveld 408576698