Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2230783004: [interpreter] Switch profiler to use frames for OSR. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-preserve-bytecode-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Switch profiler to use frames for OSR. This switches the interface of the runtime profiler to use frames as opposed to functions for performing on-stack replacement. Requests for such replacements need to target a specific frame. This will enable us to activate bytecode as well as baseline code for the same function. The existing %OptimizeOsr runtime function also had to adapted and now takes an optional stack depth to target a specific stack frame. R=bmeurer@chromium.org BUG=v8:4764 Committed: https://crrev.com/685210ecb070f408afbdeda8b1d40f148bda4ac3 Cr-Commit-Position: refs/heads/master@{#38548}

Patch Set 1 #

Patch Set 2 : Fix frame type confusion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -54 lines) Patch
M src/runtime-profiler.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/runtime-profiler.cc View 1 11 chunks +27 lines, -26 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +12 lines, -22 lines 0 comments Download
M test/mjsunit/compiler/osr-infinite.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Michael Starzinger
Benedikt: PTAL. Ross: FYI.
4 years, 4 months ago (2016-08-10 12:26:24 UTC) #4
Benedikt Meurer
Nice, LGTM.
4 years, 4 months ago (2016-08-10 12:28:40 UTC) #5
rmcilroy
LGTM.
4 years, 4 months ago (2016-08-10 14:46:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230783004/20001
4 years, 4 months ago (2016-08-10 15:57:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 15:59:15 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 15:59:41 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/685210ecb070f408afbdeda8b1d40f148bda4ac3
Cr-Commit-Position: refs/heads/master@{#38548}

Powered by Google App Engine
This is Rietveld 408576698