Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2224063003: LayoutTheme: Clean up popupInternalPadding* functions. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTheme: Clean up popupInternalPadding* functions. Replace popupInternalPaddingLeft() and popupInternalPaddingRight() with popupInternalPaddingStart() and popupInternalPaddingEnd(). We check element direction in LayoutMenuList instead of each of popupInternalPadding* implementations. This CL has no behavior changes. BUG=232333 Committed: https://crrev.com/252ae631e7f4cb0bf05b8558013f1e29ce40460a Cr-Commit-Position: refs/heads/master@{#410596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -53 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 3 chunks +10 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 chunk +7 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
keishi@, would you review this please?
4 years, 4 months ago (2016-08-09 04:45:48 UTC) #5
keishi
LGTM
4 years, 4 months ago (2016-08-09 04:59:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224063003/1
4 years, 4 months ago (2016-08-09 06:15:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:19:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:22:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/252ae631e7f4cb0bf05b8558013f1e29ce40460a
Cr-Commit-Position: refs/heads/master@{#410596}

Powered by Google App Engine
This is Rietveld 408576698