third_party/WebKit/Source/core/layout/LayoutThemeDefault.h - Issue 2224063003: LayoutTheme: Clean up popupInternalPadding* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

Issue 2224063003: LayoutTheme: Clean up popupInternalPadding* functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.h ('k') | third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

index e5f481f996f48b135c08cab7d4332a79e9db901b..4a7c151ba1dbff34d951b305da85b19abb258232 100644

--- a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

+++ b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

@@ -109,8 +109,8 @@ public:

double animationDurationForProgressBar() const override;

// These methods define the padding for the MenuList's inner block.

- int popupInternalPaddingLeft(const ComputedStyle&) const override;

- int popupInternalPaddingRight(const ComputedStyle&) const override;

+ int popupInternalPaddingStart(const ComputedStyle&) const override;

+ int popupInternalPaddingEnd(const ComputedStyle&) const override;

int popupInternalPaddingTop(const ComputedStyle&) const override;

int popupInternalPaddingBottom(const ComputedStyle&) const override;

@@ -134,7 +134,7 @@ protected:

private:

ThemePainter& painter() override { return m_painter; }

- int menuListInternalPadding(const ComputedStyle&, int paddingType) const;

+ int menuListInternalPadding(const ComputedStyle&, int padding) const;

static const RGBA32 defaultTapHighlightColor = 0x2e000000; // 18% black.

static double m_caretBlinkInterval;