third_party/WebKit/Source/core/layout/LayoutMenuList.cpp - Issue 2224063003: LayoutTheme: Clean up popupInternalPadding* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Issue 2224063003: LayoutTheme: Clean up popupInternalPadding* functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

index 842318f5db836237b6569f3b770afbefdf36a431..04556f888ff1828afbf41da571b162f38468c26b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

@@ -98,8 +98,10 @@ void LayoutMenuList::adjustInnerStyle()

innerStyle.setAlignSelfPosition(ItemPositionFlexStart);

}

- innerStyle.setPaddingLeft(Length(LayoutTheme::theme().popupInternalPaddingLeft(styleRef()), Fixed));

- innerStyle.setPaddingRight(Length(LayoutTheme::theme().popupInternalPaddingRight(styleRef()), Fixed));

+ Length paddingStart = Length(LayoutTheme::theme().popupInternalPaddingStart(styleRef()), Fixed);

+ Length paddingEnd = Length(LayoutTheme::theme().popupInternalPaddingEnd(styleRef()), Fixed);

+ innerStyle.setPaddingLeft(styleRef().direction() == LTR ? paddingStart : paddingEnd);

+ innerStyle.setPaddingRight(styleRef().direction() == LTR ? paddingEnd : paddingStart);

innerStyle.setPaddingTop(Length(LayoutTheme::theme().popupInternalPaddingTop(styleRef()), Fixed));

innerStyle.setPaddingBottom(Length(LayoutTheme::theme().popupInternalPaddingBottom(styleRef()), Fixed));

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTheme.h » ('j') | no next file with comments »