Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2223053002: Split distance vector into direction and magnitude components (Closed)

Created:
4 years, 4 months ago by dvonbeck
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split distance vector into direction and magnitude components The vector was split because the vector's users need it split, and we were creating it from the split components in the first place, so it made sense to skip that step. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223053002 Committed: https://skia.googlesource.com/skia/+/84bca78ab462314ec48614ff50315f28d5467149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/core/SkNormalBevelSource.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dvonbeck
I split the vector generation at the GeoProc. Please let me know if you think ...
4 years, 4 months ago (2016-08-08 15:17:26 UTC) #3
egdaniel
lgtm
4 years, 4 months ago (2016-08-08 17:53:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223053002/1
4 years, 4 months ago (2016-08-08 17:54:51 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:47:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/84bca78ab462314ec48614ff50315f28d5467149

Powered by Google App Engine
This is Rietveld 408576698