Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2219323002:
[iOS] Refactor build/config/ios/rules.gni. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@always-use-lipo Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[iOS] Refactor build/config/ios/rules.gni.
Add new template lipo_binary that invokes lipo to create a fat binary
from multiple single architecture binaries (supports thin builds too).
Add new template create_signed_bundle that wraps create_bundle and add
the required parameters to create a signed bundle (supports building
with code signature disabled).
Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets
to use those two templates and reduce the code duplication. Introduce
intermediate source_set target to reduce dependencies on entitlements
generation for simulator builds.
BUG=635302
Committed: https://crrev.com/17a812f225abd54e84dbe4f74c9619d4bdab3cbf
Cr-Commit-Position: refs/heads/master@{#411471}
Patch Set 1 #Patch Set 2 : Correctly forward bundle_deps_filter #Patch Set 3 : Rebase #Patch Set 4 : Rebase. #Patch Set 5 : Workaround for crbug.com/637065. #Messages
Total messages: 47 (39 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=None ========== to ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=None ==========
Description was changed from ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=None ========== to ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=635302 ==========
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2219323002/#ps120001 (title: "Workaround for crbug.com/637065.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
dpranke: can you take another look, I introduced a temporary workaround for an issue that pre-existed by was only revealed by this CL. I'm removing the workaround in a followup CL https://codereview.chromium.org/2245513002 that I'll land once the issue https://bugs.chromium.org/p/chromium/issues/detail?id=637065 is fixed.
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=635302 ========== to ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=635302 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=635302 ========== to ========== [iOS] Refactor build/config/ios/rules.gni. Add new template lipo_binary that invokes lipo to create a fat binary from multiple single architecture binaries (supports thin builds too). Add new template create_signed_bundle that wraps create_bundle and add the required parameters to create a signed bundle (supports building with code signature disabled). Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets to use those two templates and reduce the code duplication. Introduce intermediate source_set target to reduce dependencies on entitlements generation for simulator builds. BUG=635302 Committed: https://crrev.com/17a812f225abd54e84dbe4f74c9619d4bdab3cbf Cr-Commit-Position: refs/heads/master@{#411471} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/17a812f225abd54e84dbe4f74c9619d4bdab3cbf Cr-Commit-Position: refs/heads/master@{#411471} |
