use tmp allocator for images in temp shaders

use tmp allocator for images in temp shaders

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222593003

Committed: https://skia.googlesource.com/skia/+/4c1abdcd21d65bb34a6b4aea969ef4485e117e67

[reed1, 2016-08-05 20:50:22]

Description was changed from

==========
use tmp allocator for images in temp shaders

BUG=skia:
==========

to

==========
use tmp allocator for images in temp shaders

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222593003
==========

[reed1, 2016-08-05 20:50:53]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 20:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-08-05 20:51:01]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[f(malita), 2016-08-05 21:06:22]

lgtm

https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cpp
File src/image/SkImage_Raster.cpp (right):

https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cp...
src/image/SkImage_Raster.cpp:281: image.get()->ref(); // account for the
allocator being an owner
nit: 

  image = sk_ref_sp(allocator->createT<>(...))

?

[reed1, 2016-08-05 21:08:14]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-08-05 21:46:57]

https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cpp
File src/image/SkImage_Raster.cpp (right):

https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cp...
src/image/SkImage_Raster.cpp:281: image.get()->ref(); // account for the
allocator being an owner
On 2016/08/05 21:06:22, f(malita) wrote:
> nit: 
> 
>   image = sk_ref_sp(allocator->createT<>(...))
> 
> ?

Also works, but not sure it reads as clearly (or as parallel to the other sites
that have to do this trick with the allocator.

I think what I prefer is to try to write a CL that internalizes this in the
allocator itself, so it just does the "right thing" w.r.t. ref counts.

[f(malita), 2016-08-05 21:47:54]

On 2016/08/05 21:46:57, reed1 wrote:
> https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cpp
> File src/image/SkImage_Raster.cpp (right):
> 
>
https://codereview.chromium.org/2222593003/diff/1/src/image/SkImage_Raster.cp...
> src/image/SkImage_Raster.cpp:281: image.get()->ref(); // account for the
> allocator being an owner
> On 2016/08/05 21:06:22, f(malita) wrote:
> > nit: 
> > 
> >   image = sk_ref_sp(allocator->createT<>(...))
> > 
> > ?
> 
> Also works, but not sure it reads as clearly (or as parallel to the other
sites
> that have to do this trick with the allocator.
> 
> I think what I prefer is to try to write a CL that internalizes this in the
> allocator itself, so it just does the "right thing" w.r.t. ref counts.

sgtm

[reed1, 2016-08-05 21:49:22]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-08-05 21:49:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 21:50:21]

Description was changed from

==========
use tmp allocator for images in temp shaders

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222593003
==========

to

==========
use tmp allocator for images in temp shaders

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222593003

Committed:
https://skia.googlesource.com/skia/+/4c1abdcd21d65bb34a6b4aea969ef4485e117e67
==========

[commit-bot: I haz the power, 2016-08-05 21:50:22]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c1abdcd21d65bb34a6b4aea969ef4485e117e67