Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 222163002: Introduce MaybeHandle to police exception checking in handlified code. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
CC:
v8-dev, Michael Starzinger
Visibility:
Public.

Description

Introduce MaybeHandle to police exception checking in handlified code. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20457

Patch Set 1 #

Patch Set 2 : renamed to MaybeHandle and added template Throw #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : remove inheritance #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -15 lines) Patch
M src/handles.h View 1 2 3 4 5 6 3 chunks +61 lines, -1 line 0 comments Download
M src/isolate.h View 1 2 3 4 3 chunks +57 lines, -7 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8globals.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
Please take a look.
6 years, 8 months ago (2014-04-02 13:07:48 UTC) #1
Yang
6 years, 8 months ago (2014-04-02 14:09:07 UTC) #2
Michael Starzinger
Drive-by comments. https://codereview.chromium.org/222163002/diff/20001/src/handles.h File src/handles.h (right): https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode38 src/handles.h:38: class MaybeHandle { Can we get a ...
6 years, 8 months ago (2014-04-02 14:24:46 UTC) #3
Toon Verwaest
drive-by-comment https://codereview.chromium.org/222163002/diff/20001/src/handles.h File src/handles.h (right): https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode88 src/handles.h:88: class Handle : public MaybeHandle<T> { I find ...
6 years, 8 months ago (2014-04-02 14:40:24 UTC) #4
Igor Sheludko
lgtm https://codereview.chromium.org/222163002/diff/100001/src/handles.h File src/handles.h (right): https://codereview.chromium.org/222163002/diff/100001/src/handles.h#newcode108 src/handles.h:108: INLINE(Handle()) : location_(NULL) {} Extra space before {}
6 years, 8 months ago (2014-04-02 15:25:25 UTC) #5
Yang
6 years, 8 months ago (2014-04-03 05:57:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 manually as r20457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698