src/runtime.cc - Issue 222163002: Introduce MaybeHandle to police exception checking in handlified code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 222163002: Introduce MaybeHandle to police exception checking in handlified code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 67810ef1524303f463c9b3b3775d11796a3f62c7..654d41dc1d2256d8bec2ab6c9bb63d8b691ee7d2 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3238,8 +3238,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_ObjectFreeze) {

HandleScope scope(isolate);

ASSERT(args.length() == 1);

CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0);

- Handle<Object> result = JSObject::Freeze(object);

- RETURN_IF_EMPTY_HANDLE(isolate, result);

+ Handle<Object> result;

+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, JSObject::Freeze(object));

return *result;

}

« no previous file with comments | « src/objects.cc ('k') | src/v8globals.h » ('j') | no next file with comments »