Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 222143003: DevTools: Make ConsoleMessage TargetAware (Closed)

Created:
6 years, 8 months ago by sergeyv
Modified:
6 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@console-cpp-exec-context
Visibility:
Public.

Description

DevTools: Make ConsoleMessage TargetAware BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170667

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M LayoutTests/inspector/console/console-preserve-log.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-timestamp.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 7 chunks +11 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 8 chunks +14 lines, -15 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ExtensionServer.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkManager.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ScriptSnippetModel.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sergeyv
6 years, 8 months ago (2014-04-02 13:05:47 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-02 14:00:35 UTC) #2
sergeyv
6 years, 8 months ago (2014-04-02 16:15:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r170667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698