Source/devtools/front_end/ScriptSnippetModel.js - Issue 222143003: DevTools: Make ConsoleMessage TargetAware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ScriptSnippetModel.js

Issue 222143003: DevTools: Make ConsoleMessage TargetAware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@console-cpp-exec-context

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/ScriptSnippetModel.js

diff --git a/Source/devtools/front_end/ScriptSnippetModel.js b/Source/devtools/front_end/ScriptSnippetModel.js

index 993c8d18e2be81626b88e525591eac06179642c3..7e5e46e55178618205a34efee30898116c42d28b 100644

--- a/Source/devtools/front_end/ScriptSnippetModel.js

+++ b/Source/devtools/front_end/ScriptSnippetModel.js

@@ -223,6 +223,7 @@ WebInspector.ScriptSnippetModel.prototype = {

if (!scriptId) {

var consoleMessage = new WebInspector.ConsoleMessage(

+ WebInspector.console.target(),

WebInspector.ConsoleMessage.MessageSource.JS,

WebInspector.ConsoleMessage.MessageLevel.Error,

syntaxErrorMessage || "");

@@ -269,7 +270,7 @@ WebInspector.ScriptSnippetModel.prototype = {

_printRunScriptResult: function(result, wasThrown)

{

var level = (wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log);

- var message = new WebInspector.ConsoleMessage(

+ var message = new WebInspector.ConsoleMessage(WebInspector.console.target(),

WebInspector.ConsoleMessage.MessageSource.JS,

level,

"",

« no previous file with comments | « Source/devtools/front_end/NetworkManager.js ('k') | no next file » | no next file with comments »