Source/devtools/front_end/NetworkManager.js - Issue 222143003: DevTools: Make ConsoleMessage TargetAware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/NetworkManager.js

Issue 222143003: DevTools: Make ConsoleMessage TargetAware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@console-cpp-exec-context

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/NetworkManager.js

diff --git a/Source/devtools/front_end/NetworkManager.js b/Source/devtools/front_end/NetworkManager.js

index 76c0fafce15d25d36fdbb84571eb29a583ef7510..3b883b3e9c14bc22f3a828c4ede972d8d454a755 100644

--- a/Source/devtools/front_end/NetworkManager.js

+++ b/Source/devtools/front_end/NetworkManager.js

@@ -193,7 +193,8 @@ WebInspector.NetworkDispatcher.prototype = {

networkRequest.timing = response.timing;

if (!this._mimeTypeIsConsistentWithType(networkRequest)) {

- this._manager._target.consoleModel.addMessage(new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.Network,

+ var consoleModel = this._manager._target.consoleModel;

+ consoleModel.addMessage(new WebInspector.ConsoleMessage(consoleModel.target(), WebInspector.ConsoleMessage.MessageSource.Network,

WebInspector.ConsoleMessage.MessageLevel.Log,

WebInspector.UIString("Resource interpreted as %s but transferred with MIME type %s: \"%s\".", networkRequest.type.title(), networkRequest.mimeType, networkRequest.url),

WebInspector.ConsoleMessage.MessageType.Log,

« no previous file with comments | « Source/devtools/front_end/ExtensionServer.js ('k') | Source/devtools/front_end/ScriptSnippetModel.js » ('j') | no next file with comments »