Establish MojoChildConnection from BrowserChildProcessHostImpl

Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/8efa71b85282fb4df1d3836a20d086d223df714f
Committed: https://crrev.com/da988790418661f7d580f42d52be312a83589650
Cr-Original-Commit-Position: refs/heads/master@{#410937}
Cr-Commit-Position: refs/heads/master@{#413232}

[Ken Rockot(use gerrit already), 2016-08-08 22:02:27]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:07:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2016-08-08 22:10:24]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-08 22:14:19]

Description was changed from

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Changes ChildProcessHost to support ChannelMojo connection via
remote interfaces provided by its delegate, and uses this with
BCPHI in lieu of the kMojoChannelToken switch.

BUG=623396
R=ben@chromium.org
==========

to

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-08-08 22:21:04]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-08 22:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:29:55]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Ben Goodger (Google), 2016-08-08 22:32:25]

lgtm

[Ken Rockot(use gerrit already), 2016-08-08 22:37:26]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-08 22:49:27]

Patchset #3 (id:10028) has been deleted

[Ken Rockot(use gerrit already), 2016-08-09 17:32:36]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 17:33:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-09 17:34:40]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-09 17:36:40]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 17:37:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:13:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-08-09 19:17:36]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:00:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-08-09 20:06:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 20:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:52:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-09 21:02:25]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 21:03:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:03:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-08-09 23:42:42]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 23:43:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:47:37]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ken Rockot(use gerrit already), 2016-08-10 01:48:02]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:49:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-10 01:57:29]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-10 01:57:31]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-10 01:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2221153003/#ps190001
(title: "-_-")

[commit-bot: I haz the power, 2016-08-10 01:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 03:09:23]

Committed patchset #9 (id:190001)

[commit-bot: I haz the power, 2016-08-10 03:11:59]

Description was changed from

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org
==========

to

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/8efa71b85282fb4df1d3836a20d086d223df714f
Cr-Commit-Position: refs/heads/master@{#410937}
==========

[commit-bot: I haz the power, 2016-08-10 03:12:01]

Patchset 9 (id:??) landed as
https://crrev.com/8efa71b85282fb4df1d3836a20d086d223df714f
Cr-Commit-Position: refs/heads/master@{#410937}

[foolip, 2016-08-10 14:49:51]

A revert of this CL (patchset #9 id:190001) has been created in
https://codereview.chromium.org/2230283003/ by foolip@chromium.org.

The reason for reverting is:
ContentBrowserTest.BrowserCrashCallStack/RendererCrashCallStack are failing on
"Linux Tests (dbg)(1)" and "Linux Tests (dbg)(1)(32)" since this CL. Reproduced
locally and bisected to "Establish MojoChildConnection from
BrowserChildProcessHostImpl", also verified that reverting it on master locally
fixes the problem.

When it fails, the tests stall for a long time before failing. Sample from bot:

ContentBrowserTest.RendererCrashCallStack (run #1):
[ RUN      ] ContentBrowserTest.RendererCrashCallStack
[11795:11795:0810/064214:8507100974:WARNING:audio_manager.cc(317)] Multiple
instances of AudioManager detected
[11795:11795:0810/064214:8507101034:WARNING:audio_manager.cc(278)] Multiple
instances of AudioManager detected
Xlib:  extension "RANDR" missing on display ":9".
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7fdba1ca413e base::debug::StackTrace::StackTrace()
#1 0x00000145ffaa content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fdb929cf0b0 <unknown>
#3 0x7fdb92d65d2b __libc_read
#4 0x7fdba1db7e42 base::GetAppOutputInternal()
#5 0x7fdba1db7ff6 base::GetAppOutputAndError()
#6 0x000000993436
content::ContentBrowserTest_RendererCrashCallStack_Test::RunTestOnMainThread()
#7 0x00000144f6ae content::ContentBrowserTest::RunTestOnMainThreadLoop()
#8 0x00000145fd24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#9 0x0000005b969d
_ZN4base8internal13FunctorTraitsIMN4mojo13StrongBindingIN6device14BatteryMonitorEEEFvvEvE6InvokeIPS6_JEEEvS8_OT_DpOT0_
#10 0x0000005b95f1
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo13StrongBindingIN6device14BatteryMonitorEEEFvvEJPS8_EEEvOT_DpOT0_
#11 0x000001461247
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#12 0x0000014611ac
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#13 0x0000005b971e base::Callback<>::Run()
#14 0x0000015920a8 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#15 0x7fdba3457031 content::BrowserMainLoop::PreMainMessageLoopRun()
#16 0x7fdba29ee2bd
_ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_
#17 0x7fdba345f091
_ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_
#18 0x7fdba345f037
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#19 0x7fdba345ef9c
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#20 0x7fdba29ee36e base::Callback<>::Run()
#21 0x7fdba3ef057b content::StartupTaskRunner::RunAllTasksNow()
#22 0x7fdba3455033 content::BrowserMainLoop::CreateStartupTasks()
#23 0x7fdba346164d content::BrowserMainRunnerImpl::Initialize()
#24 0x000001541fc4 ShellBrowserMain()
#25 0x000001521e46 content::ShellMainDelegate::RunProcess()
#26 0x7fdba5057e3b content::RunNamedProcessTypeMain()
#27 0x7fdba505a172 content::ContentMainRunnerImpl::Run()
#28 0x7fdba5056f42 content::ContentMain()
#29 0x00000145fa46 content::BrowserTestBase::SetUp()
#30 0x00000144f52d content::ContentBrowserTest::SetUp()
#31 0x0000016a05da testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#32 0x000001691b0e testing::internal::HandleExceptionsInMethodIfSupported<>()
#33 0x0000016868a3 testing::Test::Run()
#34 0x000001687098 testing::TestInfo::Run()
#35 0x00000168763a testing::TestCase::Run()
#36 0x00000168c98c testing::internal::UnitTestImpl::RunAllTests()
#37 0x0000016a4d6a testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#38 0x0000016931ee testing::internal::HandleExceptionsInMethodIfSupported<>()
#39 0x00000168c62f testing::UnitTest::Run()
#40 0x0000014d1d11 RUN_ALL_TESTS()
#41 0x0000014d0bc2 base::TestSuite::Run()
#42 0x00000145edcc content::ContentTestLauncherDelegate::RunTestSuite()
#43 0x00000149b712 content::LaunchTests()
#44 0x00000145ec28 main
#45 0x7fdb929ba7ed __libc_start_main
#46 0x0000005612c5 <unknown>
.

[Ken Rockot(use gerrit already), 2016-08-10 14:57:08]

On 2016/08/10 at 14:49:51, foolip wrote:
> A revert of this CL (patchset #9 id:190001) has been created in
https://codereview.chromium.org/2230283003/ by foolip@chromium.org.
> 
> The reason for reverting is:
ContentBrowserTest.BrowserCrashCallStack/RendererCrashCallStack are failing on
> "Linux Tests (dbg)(1)" and "Linux Tests (dbg)(1)(32)" since this CL.
Reproduced
> locally and bisected to "Establish MojoChildConnection from
> BrowserChildProcessHostImpl", also verified that reverting it on master
locally
> fixes the problem.
> 
> When it fails, the tests stall for a long time before failing. Sample from
bot:
> 
> ContentBrowserTest.RendererCrashCallStack (run #1):
> [ RUN      ] ContentBrowserTest.RendererCrashCallStack
> [11795:11795:0810/064214:8507100974:WARNING:audio_manager.cc(317)] Multiple
instances of AudioManager detected
> [11795:11795:0810/064214:8507101034:WARNING:audio_manager.cc(278)] Multiple
instances of AudioManager detected
> Xlib:  extension "RANDR" missing on display ":9".
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7fdba1ca413e base::debug::StackTrace::StackTrace()
> #1 0x00000145ffaa content::(anonymous
namespace)::DumpStackTraceSignalHandler()
> #2 0x7fdb929cf0b0 <unknown>
> #3 0x7fdb92d65d2b __libc_read
> #4 0x7fdba1db7e42 base::GetAppOutputInternal()
> #5 0x7fdba1db7ff6 base::GetAppOutputAndError()
> #6 0x000000993436
content::ContentBrowserTest_RendererCrashCallStack_Test::RunTestOnMainThread()
> #7 0x00000144f6ae content::ContentBrowserTest::RunTestOnMainThreadLoop()
> #8 0x00000145fd24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #9 0x0000005b969d
_ZN4base8internal13FunctorTraitsIMN4mojo13StrongBindingIN6device14BatteryMonitorEEEFvvEvE6InvokeIPS6_JEEEvS8_OT_DpOT0_
> #10 0x0000005b95f1
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo13StrongBindingIN6device14BatteryMonitorEEEFvvEJPS8_EEEvOT_DpOT0_
> #11 0x000001461247
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
> #12 0x0000014611ac
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
> #13 0x0000005b971e base::Callback<>::Run()
> #14 0x0000015920a8 content::ShellBrowserMainParts::PreMainMessageLoopRun()
> #15 0x7fdba3457031 content::BrowserMainLoop::PreMainMessageLoopRun()
> #16 0x7fdba29ee2bd
_ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_
> #17 0x7fdba345f091
_ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_
> #18 0x7fdba345f037
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
> #19 0x7fdba345ef9c
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
> #20 0x7fdba29ee36e base::Callback<>::Run()
> #21 0x7fdba3ef057b content::StartupTaskRunner::RunAllTasksNow()
> #22 0x7fdba3455033 content::BrowserMainLoop::CreateStartupTasks()
> #23 0x7fdba346164d content::BrowserMainRunnerImpl::Initialize()
> #24 0x000001541fc4 ShellBrowserMain()
> #25 0x000001521e46 content::ShellMainDelegate::RunProcess()
> #26 0x7fdba5057e3b content::RunNamedProcessTypeMain()
> #27 0x7fdba505a172 content::ContentMainRunnerImpl::Run()
> #28 0x7fdba5056f42 content::ContentMain()
> #29 0x00000145fa46 content::BrowserTestBase::SetUp()
> #30 0x00000144f52d content::ContentBrowserTest::SetUp()
> #31 0x0000016a05da
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #32 0x000001691b0e testing::internal::HandleExceptionsInMethodIfSupported<>()
> #33 0x0000016868a3 testing::Test::Run()
> #34 0x000001687098 testing::TestInfo::Run()
> #35 0x00000168763a testing::TestCase::Run()
> #36 0x00000168c98c testing::internal::UnitTestImpl::RunAllTests()
> #37 0x0000016a4d6a
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #38 0x0000016931ee testing::internal::HandleExceptionsInMethodIfSupported<>()
> #39 0x00000168c62f testing::UnitTest::Run()
> #40 0x0000014d1d11 RUN_ALL_TESTS()
> #41 0x0000014d0bc2 base::TestSuite::Run()
> #42 0x00000145edcc content::ContentTestLauncherDelegate::RunTestSuite()
> #43 0x00000149b712 content::LaunchTests()
> #44 0x00000145ec28 main
> #45 0x7fdb929ba7ed __libc_start_main
> #46 0x0000005612c5 <unknown>
> .

I'm seeing these failures on other bots before this patch landed:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29?num...

[Ken Rockot(use gerrit already), 2016-08-18 21:12:53]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 21:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:38:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-08-19 16:32:33]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:32:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-19 16:47:09]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-19 16:47:14]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-19 16:47:15]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2221153003/#ps250001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-19 16:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-19 16:50:05]

Turns out Android WebView does some blocking work on the FILE thread and that
can deadlock in some cases if it blocks the Catalog from resolving a service
name.

I've moved the Catalog to the blocking pool, so this should be good to land now.

[commit-bot: I haz the power, 2016-08-19 19:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:10:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-08-19 19:11:08]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:11:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 20:47:04]

Committed patchset #12 (id:250001)

[commit-bot: I haz the power, 2016-08-19 20:48:45]

Description was changed from

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/8efa71b85282fb4df1d3836a20d086d223df714f
Cr-Commit-Position: refs/heads/master@{#410937}
==========

to

==========
Establish MojoChildConnection from BrowserChildProcessHostImpl

Rather than have individual BrowserChildProcessHostImpl users
create their own connection, this moves all that junk into BCPHI
and allows its users to configure it with a service name and
instance ID.

Also changes ChildProcessHost to support ChannelMojo connection
via remote interfaces provided by its delegate, and uses this
in conjunction with the BCPHI changes. Eliminates one more use
of kMojoChannelToken.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/8efa71b85282fb4df1d3836a20d086d223df714f
Committed: https://crrev.com/da988790418661f7d580f42d52be312a83589650
Cr-Original-Commit-Position: refs/heads/master@{#410937}
Cr-Commit-Position: refs/heads/master@{#413232}
==========

[commit-bot: I haz the power, 2016-08-19 20:48:47]

Patchset 12 (id:??) landed as
https://crrev.com/da988790418661f7d580f42d52be312a83589650
Cr-Commit-Position: refs/heads/master@{#413232}