Remove Channel token from InProcessChildThreadParams

Remove Channel token from InProcessChildThreadParams

All in-process child threads now acquire a ChannelMojo
interface from a shell connection. The Channel pipe
token is no longer needed.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/d4184c454d453d76627a5b4d21454b1ba476fb9b
Cr-Commit-Position: refs/heads/master@{#413245}

[Ken Rockot(use gerrit already), 2016-08-09 19:51:25]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:52:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 19:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:58:03]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-08-09 20:12:19]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 20:12:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 21:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:01:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-10 02:41:45]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 02:42:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 03:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 03:47:43]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-08-10 04:45:59]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 04:46:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 06:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 06:13:37]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2016-08-10 14:24:04]

lgtm

https://codereview.chromium.org/2226403002/diff/60001/content/renderer/render...
File content/renderer/render_thread_impl_browsertest.cc (right):

https://codereview.chromium.org/2226403002/diff/60001/content/renderer/render...
content/renderer/render_thread_impl_browsertest.cc:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
this test seems like it'll be completely re-done/invalidated by the network
service work fwiw

[Ken Rockot(use gerrit already), 2016-08-10 14:50:30]

On 2016/08/10 at 14:24:04, ben wrote:
> lgtm
> 
>
https://codereview.chromium.org/2226403002/diff/60001/content/renderer/render...
> File content/renderer/render_thread_impl_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2226403002/diff/60001/content/renderer/render...
> content/renderer/render_thread_impl_browsertest.cc:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
> this test seems like it'll be completely re-done/invalidated by the network
service work fwiw

Makes sense. I considered deleting them, but the adaptation wasn't too painful.
If nothing else at least they now also serve as a decent reduced test case for
MojoChildConnection+ChannelMojo...

[Ken Rockot(use gerrit already), 2016-08-18 22:02:53]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 22:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 23:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 23:01:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-19 17:16:30]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-19 19:08:46]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-19 19:08:48]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-19 19:08:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2226403002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-19 19:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:09:19]

This CL has an open dependency (Issue 2221153003 Patch 250001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Ken Rockot(use gerrit already), 2016-08-19 21:27:14]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:28:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:35:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-19 21:44:25]

Description was changed from

==========
Remove Channel token from InProcessChildThreadParams

All in-process child threads now acquire a ChannelMojo
interface from a shell connection. The Channel pipe
token is no longer needed.

BUG=623396
R=ben@chromium.org
==========

to

==========
Remove Channel token from InProcessChildThreadParams

All in-process child threads now acquire a ChannelMojo
interface from a shell connection. The Channel pipe
token is no longer needed.

BUG=623396
R=ben@chromium.org

Committed: https://crrev.com/d4184c454d453d76627a5b4d21454b1ba476fb9b
Cr-Commit-Position: refs/heads/master@{#413245}
==========

[commit-bot: I haz the power, 2016-08-19 21:44:26]

Patchset 6 (id:??) landed as
https://crrev.com/d4184c454d453d76627a5b4d21454b1ba476fb9b
Cr-Commit-Position: refs/heads/master@{#413245}