services/shell/service_manager.cc - Issue 2221153003: Establish MojoChildConnection from BrowserChildProcessHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/service_manager.cc

Issue 2221153003: Establish MojoChildConnection from BrowserChildProcessHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-channel

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/shell/service_manager.cc

diff --git a/services/shell/service_manager.cc b/services/shell/service_manager.cc

index f0aa9d4f046d869d3e5d5afed5e0ad1fba257811..29492011d5f75ade089360989e847c4657330e95 100644

--- a/services/shell/service_manager.cc

+++ b/services/shell/service_manager.cc

@@ -579,8 +579,8 @@ mojom::Resolver* ServiceManager::GetResolver(const Identity& identity) {

void ServiceManager::TerminateServiceManagerConnections() {

Instance* instance = GetExistingInstance(CreateServiceManagerIdentity());

- DCHECK(instance);

- OnInstanceError(instance);

+ if (instance)

+ OnInstanceError(instance);

}

void ServiceManager::OnInstanceError(Instance* instance) {

« no previous file with comments | « services/catalog/reader.cc ('k') | no next file » | no next file with comments »