Use smart pointers for class owned pointers in xfa/fxbarcode

Use smart pointers for class owned pointers in xfa/fxbarcode

For classes under xfa/fxbarcode, use smart pointers instead
of raw pointer to make memory management easier.

Also fix some styling issues along the changes.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/e76203dbefd1df075a063ee019c3908513f6bee5

[Wei Li, 2016-08-08 22:50:01]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:50:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-08-08 22:53:33]

Description was changed from

==========
Use smart pointers for class owned pointers in xfa/fxbarcode

For classes under xfa/fxbarcode, use smart pointers instead
of raw pointer to make memory management easier.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers in xfa/fxbarcode

For classes under xfa/fxbarcode, use smart pointers instead
of raw pointer to make memory management easier.

Also fix some styling issues along the changes.

BUG=pdfium:518
==========

[commit-bot: I haz the power, 2016-08-08 23:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:28:25]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-08 23:56:25]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-08 23:56:26]

pls review, thanks

[Lei Zhang, 2016-08-09 00:23:43]

looks good

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/BC_TwoDimWrit...
File xfa/fxbarcode/BC_TwoDimWriter.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/BC_TwoDimWrit...
xfa/fxbarcode/BC_TwoDimWriter.h:30: virtual int32_t GetErrorCorrectionLevel()
const;
BTW, I don't think anyone is overriding this.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
File xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h:37: static
CBC_ReedSolomonGF256* QRCodeFild;
Any reason these can't be removed here and declared in BC_ReedSolomonGF256.cpp
in an anonymous namespace?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h:37: static
CBC_ReedSolomonGF256* QRCodeFild;
s/Fild/Field/ ?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417.cpp (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417.cpp:385: : m_compact(FALSE),
Just delegate to the ctor below?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417.h:21: CBC_PDF417(FX_BOOL compact);
explicit

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoder.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoder.h:18: static const int32_t kNumMaskPatterns = 8;
constexpr?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoder.h:23: static FX_BOOL IsValidMaskPattern(int32_t
maskPattern);
Return a bool?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoderBlockPair.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoderBlockPair.h:20: CBC_CommonByteArray*
GetDataBytes() const;
Can these return const CBC_CommonByteArray* ?

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoderMode.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoderMode.h:50: CFX_ByteString m_name;
const as well?

[Wei Li, 2016-08-09 07:16:06]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 07:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:36:42]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-09 17:30:53]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-08-09 17:31:50]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 17:32:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 17:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 17:48:13]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-09 19:31:23]

thanks

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/BC_TwoDimWrit...
File xfa/fxbarcode/BC_TwoDimWriter.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/BC_TwoDimWrit...
xfa/fxbarcode/BC_TwoDimWriter.h:30: virtual int32_t GetErrorCorrectionLevel()
const;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> BTW, I don't think anyone is overriding this.

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
File xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h:37: static
CBC_ReedSolomonGF256* QRCodeFild;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> Any reason these can't be removed here and declared in BC_ReedSolomonGF256.cpp
> in an anonymous namespace?

It is also used on other classes such as BC_QRCoderEncoder.cpp

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/common/reedso...
xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h:37: static
CBC_ReedSolomonGF256* QRCodeFild;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> s/Fild/Field/ ?

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417.cpp (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417.cpp:385: : m_compact(FALSE),
On 2016/08/09 00:23:43, Lei Zhang wrote:
> Just delegate to the ctor below?

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417.h:21: CBC_PDF417(FX_BOOL compact);
On 2016/08/09 00:23:43, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoder.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoder.h:18: static const int32_t kNumMaskPatterns = 8;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> constexpr?

Probably no difference in this case, but constexpr may be more explicit.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoder.h:23: static FX_BOOL IsValidMaskPattern(int32_t
maskPattern);
On 2016/08/09 00:23:43, Lei Zhang wrote:
> Return a bool?

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoderBlockPair.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoderBlockPair.h:20: CBC_CommonByteArray*
GetDataBytes() const;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> Can these return const CBC_CommonByteArray* ?

Done.

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
File xfa/fxbarcode/qrcode/BC_QRCoderMode.h (right):

https://codereview.chromium.org/2221023003/diff/1/xfa/fxbarcode/qrcode/BC_QRC...
xfa/fxbarcode/qrcode/BC_QRCoderMode.h:50: CFX_ByteString m_name;
On 2016/08/09 00:23:43, Lei Zhang wrote:
> const as well?

Done.

[Lei Zhang, 2016-08-09 20:33:13]

lgtm

[Lei Zhang, 2016-08-09 20:44:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:45:07]

Description was changed from

==========
Use smart pointers for class owned pointers in xfa/fxbarcode

For classes under xfa/fxbarcode, use smart pointers instead
of raw pointer to make memory management easier.

Also fix some styling issues along the changes.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers in xfa/fxbarcode

For classes under xfa/fxbarcode, use smart pointers instead
of raw pointer to make memory management easier.

Also fix some styling issues along the changes.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/e76203dbefd1df075a063ee019c3908513f6...
==========

[commit-bot: I haz the power, 2016-08-09 20:45:08]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e76203dbefd1df075a063ee019c3908513f6...