Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: xfa/fxbarcode/qrcode/BC_QRCoderBlockPair.h

Issue 2221023003: Use smart pointers for class owned pointers in xfa/fxbarcode (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_ 7 #ifndef XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_
8 #define XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_ 8 #define XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_
9 9
10 #include <memory>
11
10 class CBC_CommonByteArray; 12 class CBC_CommonByteArray;
13
11 class CBC_QRCoderBlockPair { 14 class CBC_QRCoderBlockPair {
12 private:
13 CBC_CommonByteArray* m_dataBytes;
14 CBC_CommonByteArray* m_errorCorrectionBytes;
15
16 public: 15 public:
17 CBC_QRCoderBlockPair(CBC_CommonByteArray* data, 16 CBC_QRCoderBlockPair(std::unique_ptr<CBC_CommonByteArray> data,
18 CBC_CommonByteArray* errorCorrection); 17 std::unique_ptr<CBC_CommonByteArray> errorCorrection);
19 virtual ~CBC_QRCoderBlockPair(); 18 virtual ~CBC_QRCoderBlockPair();
20 19
21 CBC_CommonByteArray* GetDataBytes(); 20 CBC_CommonByteArray* GetDataBytes() const;
Lei Zhang 2016/08/09 00:23:43 Can these return const CBC_CommonByteArray* ?
Wei Li 2016/08/09 19:31:23 Done.
22 CBC_CommonByteArray* GetErrorCorrectionBytes(); 21 CBC_CommonByteArray* GetErrorCorrectionBytes() const;
22
23 private:
24 std::unique_ptr<CBC_CommonByteArray> m_dataBytes;
25 std::unique_ptr<CBC_CommonByteArray> m_errorCorrectionBytes;
23 }; 26 };
24 27
25 #endif // XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_ 28 #endif // XFA_FXBARCODE_QRCODE_BC_QRCODERBLOCKPAIR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698