xfa/fxbarcode/common/BC_CommonByteArray.h - Issue 2221023003: Use smart pointers for class owned pointers in xfa/fxbarcode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxbarcode/common/BC_CommonByteArray.h

Issue 2221023003: Use smart pointers for class owned pointers in xfa/fxbarcode (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_	7 #ifndef XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_

8 #define XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_	8 #define XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_

9	9

10 #include "core/fxcrt/include/fx_basic.h"	10 #include "core/fxcrt/include/fx_basic.h"

11	11

	12 // TODO(weili): The usage of this class should be replaced by

	13 // std::vector<uint8_t>.

12 class CBC_CommonByteArray {	14 class CBC_CommonByteArray {

13 public:	15 public:

14 CBC_CommonByteArray();	16 CBC_CommonByteArray();

15 explicit CBC_CommonByteArray(int32_t size);	17 explicit CBC_CommonByteArray(int32_t size);

16 CBC_CommonByteArray(uint8_t* byteArray, int32_t size);	18 CBC_CommonByteArray(uint8_t* byteArray, int32_t size);

17 virtual ~CBC_CommonByteArray();	19 virtual ~CBC_CommonByteArray();

18	20

19 int32_t At(int32_t index);	21 int32_t At(int32_t index) const;

	22 int32_t Size() const;

	23 FX_BOOL IsEmpty() const;

20 void Set(int32_t index, int32_t value);	24 void Set(int32_t index, int32_t value);

21 int32_t Size();

22 FX_BOOL IsEmpty();

23 void AppendByte(int32_t value);	25 void AppendByte(int32_t value);

24 void Reserve(int32_t capacity);	26 void Reserve(int32_t capacity);

25 void Set(uint8_t* source, int32_t offset, int32_t count);	27 void Set(uint8_t* source, int32_t offset, int32_t count);

26 void Set(CFX_ByteArray* source, int32_t offset, int32_t count);	28 void Set(CFX_ByteArray* source, int32_t offset, int32_t count);

27	29

28 private:	30 private:

29 int32_t m_size;	31 int32_t m_size;

30 int32_t m_index;	32 int32_t m_index;

31 uint8_t* m_bytes;	33 uint8_t* m_bytes;

32 };	34 };

33	35

34 #endif // XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_	36 #endif // XFA_FXBARCODE_COMMON_BC_COMMONBYTEARRAY_H_

OLD	NEW

« no previous file with comments | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxbarcode/common/BC_CommonByteArray.cpp » ('j') | no next file with comments »