Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2220623002: DialogSurfaceHolder implementation.

Created:
4 years, 4 months ago by liberato (no reviews please)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@just_surface_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DialogSurfaceHolder implementation. This CL follows up https://codereview.chromium.org/2178973004/ with the implementation for DialogSurfaceHolder and callbacks. It also updates DialogSurfaceManager to create them properly. BUG=618368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : removed extra files #

Patch Set 3 : added catch for findbugs #

Patch Set 4 : removed some unused usings #

Patch Set 5 : panel => media dialog type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+780 lines, -14 lines) Patch
M media/base/android/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
A media/base/android/dialog_surface_callback.h View 1 chunk +79 lines, -0 lines 0 comments Download
A media/base/android/dialog_surface_callback.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M media/base/android/dialog_surface_holder.h View 2 chunks +30 lines, -2 lines 0 comments Download
A media/base/android/dialog_surface_holder.cc View 1 2 3 1 chunk +82 lines, -0 lines 0 comments Download
M media/base/android/dialog_surface_manager.cc View 2 chunks +7 lines, -4 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/DialogSurfaceCallback.java View 1 chunk +34 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/DialogSurfaceHolder.java View 1 2 3 4 1 chunk +307 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/DialogSurfaceHolderWrapper.java View 1 chunk +57 lines, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/DialogSurfaceManager.java View 5 chunks +7 lines, -8 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (12 generated)
liberato (no reviews please)
4 years, 4 months ago (2016-08-08 22:08:21 UTC) #12
Hi all.

This is 2/2 for the core DialogSurface code.  while
https://codereview.chromium.org/2178973004 is still out for review, it seems
like we're fairly close to converging.

i figured that i'd send this out now, both for context and while the previous
one is still relatively fresh in your minds.  it adds the implementation for
DialogSurfaceHolder.

sievers: it doesn't try to address activity switching yet.

thanks
-fl

Powered by Google App Engine
This is Rietveld 408576698