Issue 2247383002: Add support for tab migration to DialogSurface

Created:
4 years, 4 months ago by liberato (no reviews please)

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews, jam, darin-cc_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@remaining_surface_manager

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add support for tab migration to DialogSurface When tabs are moved between activities (e.g., "open in chrome"), the window token may change. This CL detects this condition and causes DialogSurface to dismiss / recreate the dialog as needed. BUG=

Patch Set 1 #

Patch Set 2 : removed WAITING_FOR_DESTROY #

Patch Set 3 : cleaned up logs #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+401 lines, -56 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		3 chunks	+38 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/DialogSurfaceActivityMapper.java	View	1 2	3 chunks	+121 lines, -3 lines	0 comments	Download
M	media/base/android/java/src/org/chromium/media/DialogSurfaceHolder.java	View	1 2	11 chunks	+227 lines, -50 lines	0 comments	Download
M	media/base/android/java/src/org/chromium/media/IDialogSurfaceActivityMapper.aidl	View		1 chunk	+9 lines, -2 lines	0 comments	Download
M	media/base/android/java/src/org/chromium/media/IDialogSurfaceHolder.aidl	View		1 chunk	+4 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2220623002 Patch 80001

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

liberato (no reviews please)

4 years, 2 months ago (2016-10-07 20:48:36 UTC) #4

i don't know if this is similar to multi-window or not, but maybe something
useful.

added you as cc, though feel free to review if you want :)

thanks
-fl

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages