Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2220293002: Roll WebGL b57946d..46ec84c (Closed)

Created:
4 years, 4 months ago by qiankun
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL b57946d..46ec84c https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b57946d..46ec84c BUG=634813 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/facabd3224aecbcab4bea9daadad31c67488d78c Cr-Commit-Position: refs/heads/master@{#410520}

Patch Set 1 #

Patch Set 2 : update expectations #

Total comments: 2

Patch Set 3 : move to all platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
qiankun
I rolled conformance/glsl/bugs/invariant-does-not-leak-across-shaders.html into chrome. We should still wait https://chromium-review.googlesource.com/366720/ to fix it.
4 years, 4 months ago (2016-08-08 13:43:17 UTC) #2
Zhenyao Mo
lgtm https://codereview.chromium.org/2220293002/diff/20001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2220293002/diff/20001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode32 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:32: self.Fail('conformance/glsl/bugs/' + Move this below to the section ...
4 years, 4 months ago (2016-08-08 16:34:58 UTC) #4
Ken Russell (switch to Gerrit)
LGTM with Mo's comment addressed.
4 years, 4 months ago (2016-08-08 17:33:10 UTC) #5
qiankun
https://codereview.chromium.org/2220293002/diff/20001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2220293002/diff/20001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode32 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:32: self.Fail('conformance/glsl/bugs/' + On 2016/08/08 16:34:58, Zhenyao Mo wrote: > ...
4 years, 4 months ago (2016-08-08 23:39:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220293002/40001
4 years, 4 months ago (2016-08-08 23:44:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 02:14:05 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:15:25 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/facabd3224aecbcab4bea9daadad31c67488d78c
Cr-Commit-Position: refs/heads/master@{#410520}

Powered by Google App Engine
This is Rietveld 408576698