Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2220123002: Update "git cl format" for GN changes. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, agable
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update "git cl format" for GN changes. "gn format" changed to remove the --in-place argument. This updates the instructions for formatting and fixes existing usage. git cl format --diff never worked, it just printed the full formatted output unconditionally. This change improves things slightly by indicating there's a diff for a file. A proper diff can be hooked up in a later stage if somebody so desires. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4b8ed59b7bab45995f48623f83dd3d46b3854f98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M git_cl.py View 1 chunk +17 lines, -8 lines 0 comments Download
M presubmit_canned_checks.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
brettw
4 years, 4 months ago (2016-08-05 21:56:33 UTC) #2
brettw
4 years, 4 months ago (2016-08-05 22:35:25 UTC) #8
agable
lgtm
4 years, 4 months ago (2016-08-05 23:06:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220123002/1
4 years, 4 months ago (2016-08-05 23:15:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/4b8ed59b7bab45995f48623f83dd3d46b3854f98
4 years, 4 months ago (2016-08-05 23:19:17 UTC) #16
Dirk Pranke
4 years, 4 months ago (2016-08-08 22:19:24 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698