presubmit_canned_checks.py - Issue 2220123002: Update "git cl format" for GN changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: presubmit_canned_checks.py

Issue 2220123002: Update "git cl format" for GN changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Generic presubmit checks that can be reused by other presubmit checks."""	5 """Generic presubmit checks that can be reused by other presubmit checks."""

6	6

7 import os as _os	7 import os as _os

8 _HERE = _os.path.dirname(_os.path.abspath(__file__))	8 _HERE = _os.path.dirname(_os.path.abspath(__file__))

9	9

10 # Justifications for each filter:	10 # Justifications for each filter:

(...skipping 1160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1171 include_deletes=False,	1171 include_deletes=False,

1172 file_filter=lambda x: x.LocalPath().endswith('.gn') or	1172 file_filter=lambda x: x.LocalPath().endswith('.gn') or

1173 x.LocalPath().endswith('.gni') or	1173 x.LocalPath().endswith('.gni') or

1174 x.LocalPath().endswith('.typemap'))	1174 x.LocalPath().endswith('.typemap'))

1175 warnings = []	1175 warnings = []

1176 for f in affected_files:	1176 for f in affected_files:

1177 cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]	1177 cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]

1178 rc = gn.main(cmd)	1178 rc = gn.main(cmd)

1179 if rc == 2:	1179 if rc == 2:

1180 warnings.append(output_api.PresubmitPromptWarning(	1180 warnings.append(output_api.PresubmitPromptWarning(

1181 '%s requires formatting. Please run `gn format --in-place %s`.' % (	1181 '%s requires formatting. Please run:\n gn format %s' % (

1182 f.AbsoluteLocalPath(), f.LocalPath())))	1182 f.AbsoluteLocalPath(), f.LocalPath())))

1183 # It's just a warning, so ignore other types of failures assuming they'll be	1183 # It's just a warning, so ignore other types of failures assuming they'll be

1184 # caught elsewhere.	1184 # caught elsewhere.

1185 return warnings	1185 return warnings

OLD	NEW

« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »