presubmit_canned_checks.py - Issue 2220123002: Update "git cl format" for GN changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 2220123002: Update "git cl format" for GN changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 15e24e29d86e338ec4e6ef25c7997b6342e6c3ed..6d524091ef74e9ab43da6d64b351f2651aeb9eb8 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -1178,7 +1178,7 @@ def CheckGNFormatted(input_api, output_api):

rc = gn.main(cmd)

if rc == 2:

warnings.append(output_api.PresubmitPromptWarning(

- '%s requires formatting. Please run `gn format --in-place %s`.' % (

+ '%s requires formatting. Please run:\n gn format %s' % (

f.AbsoluteLocalPath(), f.LocalPath())))

# It's just a warning, so ignore other types of failures assuming they'll be

# caught elsewhere.

« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »