Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2219843002: headless: Make API generator more robust against weird enum literals (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
altimin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Make API generator more robust against weird enum literals This patch makes the headless client API generator dael with enum literals that don't directly translate to valid C++ identifiers (e.g., NaN, Infinity, -Infinity, -0). BUG=546953 Committed: https://crrev.com/c57b829ff3345289ddfd92a305807d3a38908088 Cr-Commit-Position: refs/heads/master@{#410044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M headless/lib/browser/client_api_generator.py View 2 chunks +12 lines, -4 lines 0 comments Download
M headless/lib/browser/client_api_generator_unittest.py View 1 chunk +5 lines, -3 lines 0 comments Download
M headless/lib/browser/type_conversions_h.template View 3 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/types_h.template View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
This should make our bot green again. PTAL.
4 years, 4 months ago (2016-08-05 11:27:06 UTC) #3
altimin
lgtm
4 years, 4 months ago (2016-08-05 11:57:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219843002/1
4 years, 4 months ago (2016-08-05 12:21:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:53:41 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:55:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c57b829ff3345289ddfd92a305807d3a38908088
Cr-Commit-Position: refs/heads/master@{#410044}

Powered by Google App Engine
This is Rietveld 408576698