Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: headless/lib/browser/client_api_generator_unittest.py

Issue 2219843002: headless: Make API generator more robust against weird enum literals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/client_api_generator.py ('k') | headless/lib/browser/type_conversions_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/client_api_generator_unittest.py
diff --git a/headless/lib/browser/client_api_generator_unittest.py b/headless/lib/browser/client_api_generator_unittest.py
index 0cd7df3fd37968ffd63ed4cee18716c0c025a422..67ff253752991322b9b21b5ec3d920955150b547 100644
--- a/headless/lib/browser/client_api_generator_unittest.py
+++ b/headless/lib/browser/client_api_generator_unittest.py
@@ -35,9 +35,11 @@ class ClientApiGeneratorTest(unittest.TestCase):
self.assertEqual(client_api_generator.CamelCaseToHackerStyle('LoLoLoL'),
'lo_lo_lol')
- def test_MangleEnum(self):
- self.assertEqual(client_api_generator.MangleEnum('FOO'), 'FOO')
- self.assertEqual(client_api_generator.MangleEnum('NULL'), 'NONE')
+ def test_SanitizeLiteralEnum(self):
+ self.assertEqual(client_api_generator.SanitizeLiteral('foo'), 'foo')
+ self.assertEqual(client_api_generator.SanitizeLiteral('null'), 'none')
+ self.assertEqual(client_api_generator.SanitizeLiteral('Infinity'),
+ 'InfinityValue')
def test_PatchFullQualifiedRefs(self):
json_api = {
« no previous file with comments | « headless/lib/browser/client_api_generator.py ('k') | headless/lib/browser/type_conversions_h.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698