headless: Make API generator more robust against weird enum literals

headless/lib/browser/client_api_generator.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import os.path
 import sys
 import re
 try:
   import json
@@ skipping 41 matching lines @@
 
 
 def CamelCaseToHackerStyle(name):
   # Do two passes to insert '_' chars to deal with overlapping matches (e.g.,
   # 'LoLoLoL').
   name = re.sub(r'([^_])([A-Z][a-z]+?)', r'\1_\2', name)
   name = re.sub(r'([^_])([A-Z][a-z]+?)', r'\1_\2', name)
   return name.lower()
 
 
-def MangleEnum(value):
-  # Rename NULL enumeration values to avoid a clash with the actual NULL.
-  return 'NONE' if value == 'NULL' else value
+def SanitizeLiteral(literal):
+  return {
+    # Rename null enumeration values to avoid a clash with the NULL macro.
+    'null': 'none',
+    # Rename mathematical constants to avoid colliding with C macros.
+    'Infinity': 'InfinityValue',
+    '-Infinity': 'NegativeInfinityValue',
+    'NaN': 'NaNValue',
+    # Turn negative zero into a safe identifier.
+    '-0': 'NegativeZeroValue',
+  }.get(literal, literal)
 
 
 def InitializeJinjaEnv(cache_dir):
   jinja_env = jinja2.Environment(
       loader=jinja2.FileSystemLoader(templates_dir),
       # Bytecode cache is not concurrency-safe unless pre-cached:
       # if pre-cached this is read-only, but writing creates a race condition.
       bytecode_cache=jinja2.FileSystemBytecodeCache(cache_dir),
       keep_trailing_newline=True,  # Newline-terminate generated files.
       lstrip_blocks=True,  # So we can indent control flow tags.
       trim_blocks=True)
   jinja_env.filters.update({
     'to_title_case': ToTitleCase,
     'dash_to_camelcase': DashToCamelCase,
     'camelcase_to_hacker_style': CamelCaseToHackerStyle,
-    'mangle_enum': MangleEnum,
+    'sanitize_literal': SanitizeLiteral,
   })
   jinja_env.add_extension('jinja2.ext.loopcontrols')
   return jinja_env
 
 
 def PatchFullQualifiedRefs(json_api):
   def PatchFullQualifiedRefsInDomain(json, domain_name):
     if isinstance(json, list):
       for item in json:
         PatchFullQualifiedRefsInDomain(item, domain_name)
@@ skipping 322 matching lines @@
   json_api, output_dirname = ParseArguments(sys.argv[1:])
   jinja_env = InitializeJinjaEnv(output_dirname)
   PatchHiddenCommandsAndEvents(json_api)
   SynthesizeCommandTypes(json_api)
   SynthesizeEventTypes(json_api)
   PatchFullQualifiedRefs(json_api)
   CreateTypeDefinitions(json_api)
   Generate(jinja_env, output_dirname, json_api, 'types', ['cc', 'h'])
   Generate(jinja_env, output_dirname, json_api, 'type_conversions', ['h'])
   GenerateDomains(jinja_env, output_dirname, json_api, 'domain', ['cc', 'h'])