Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2219673002: Remove empty namespace assertion from impl/memory. (Closed)

Created:
4 years, 4 months ago by iannucci
Modified:
4 years, 4 months ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M impl/memory/datastore.go View 5 chunks +0 lines, -28 lines 0 comments Download
M impl/memory/datastore_test.go View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iannucci
4 years, 4 months ago (2016-08-05 00:45:06 UTC) #1
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-05 00:48:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219673002/1
4 years, 4 months ago (2016-08-05 00:59:01 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 01:07:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/75ab19e8b10391a5dd466b1896433fad054ad811

Powered by Google App Engine
This is Rietveld 408576698