Remove empty namespace assertion from impl/memory.

impl/memory/datastore.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package memory
 
 import (
         "errors"
         "fmt"
 
@@ skipping 87 matching lines @@
 func (d *dsImpl) DeleteMulti(keys []*ds.Key, cb ds.DeleteMultiCB) error {
         d.data.delMulti(keys, cb)
         return nil
 }
 
 func (d *dsImpl) DecodeCursor(s string) (ds.Cursor, error) {
         return newCursor(s)
 }
 
 func (d *dsImpl) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {
-        if err := assertQueryNamespace(d.ns, d.hasNS); err != nil {
-                return err
-        }
-
         idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
         err := executeQuery(fq, d.data.aid, d.ns, false, idx, head, cb)
         if d.data.maybeAutoIndex(err) {
                 idx, head = d.data.getQuerySnaps(!fq.EventuallyConsistent())
                 err = executeQuery(fq, d.data.aid, d.ns, false, idx, head, cb)
         }
         return err
 }
 
 func (d *dsImpl) Count(fq *ds.FinalizedQuery) (ret int64, err error) {
-        if err := assertQueryNamespace(d.ns, d.hasNS); err != nil {
-                return 0, err
-        }
-
         idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
         ret, err = countQuery(fq, d.data.aid, d.ns, false, idx, head)
         if d.data.maybeAutoIndex(err) {
                 idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
                 ret, err = countQuery(fq, d.data.aid, d.ns, false, idx, head)
         }
         return
 }
 
 func (d *dsImpl) AddIndexes(idxs ...*ds.IndexDefinition) {
@@ skipping 73 matching lines @@
         return d.data.run(func() error {
                 return d.data.delMulti(keys, cb)
         })
 }
 
 func (d *txnDsImpl) DecodeCursor(s string) (ds.Cursor, error) {
         return newCursor(s)
 }
 
 func (d *txnDsImpl) Run(q *ds.FinalizedQuery, cb ds.RawRunCB) error {
-        if err := assertQueryNamespace(d.ns, d.hasNS); err != nil {
-                return err
-        }
-
         // note that autoIndex has no effect inside transactions. This is because
         // the transaction guarantees a consistent view of head at the time that the
         // transaction opens. At best, we could add the index on head, but then return
         // the error anyway, but adding the index then re-snapping at head would
         // potentially reveal other entities not in the original transaction snapshot.
         //
         // It's possible that if you have full-consistency and also auto index enabled
         // that this would make sense... but at that point you should probably just
         // add the index up front.
         return executeQuery(q, d.data.parent.aid, d.ns, true, d.data.snap, d.data.snap, cb)
 }
 
 func (d *txnDsImpl) Count(fq *ds.FinalizedQuery) (ret int64, err error) {
-        if err := assertQueryNamespace(d.ns, d.hasNS); err != nil {
-                return 0, err
-        }
-
         return countQuery(fq, d.data.parent.aid, d.ns, true, d.data.snap, d.data.snap)
 }
 
 func (*txnDsImpl) RunInTransaction(func(c context.Context) error, *ds.TransactionOptions) error {
         return errors.New("datastore: nested transactions are not supported")
 }
 
 func (*txnDsImpl) Testable() ds.Testable {
         return nil
 }
-
-func assertQueryNamespace(ns string, hasNS bool) error {
-        if ns == "" && hasNS {
-                // The user has set an empty namespace. Datastore does not support this
-                // for queries.
-                //
-                // Bug on file is:
-                // https://code.google.com/p/googleappengine/issues/detail?id=12914
-                return errors.New("namespace may not be present and empty")
-        }
-        return nil
-}