Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: impl/memory/datastore_test.go

Issue 2219673002: Remove empty namespace assertion from impl/memory. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/memory/datastore.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/memory/datastore_test.go
diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go
index 225e9f91b6670f3adc138e0b68a30724c042bd28..fa4dbefb7264e49e36af1d3b654e4b5d32f4a948 100644
--- a/impl/memory/datastore_test.go
+++ b/impl/memory/datastore_test.go
@@ -596,21 +596,13 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
So(countErr, ShouldBeNil)
})
- Convey("With an non-empty namespace installed, can Put, Get, Query, and Count.", func() {
+ Convey("With a namespace installed, can Put, Get, Query, and Count.", func() {
putErr, getErr, queryErr, countErr := run(infoS.Get(c).MustNamespace("foo"), txn)
So(putErr, ShouldBeNil)
So(getErr, ShouldBeNil)
So(queryErr, ShouldBeNil)
So(countErr, ShouldBeNil)
})
-
- Convey("With an empty namespace installed, can Put and Get, but not Query or Count.", func() {
- putErr, getErr, queryErr, countErr := run(infoS.Get(c).MustNamespace(""), txn)
- So(putErr, ShouldBeNil)
- So(getErr, ShouldBeNil)
- So(queryErr, ShouldErrLike, "namespace may not be present and empty")
- So(countErr, ShouldErrLike, "namespace may not be present and empty")
- })
})
}
})
« no previous file with comments | « impl/memory/datastore.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698