Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2218673002: Use -Wno-unused-const-variable only on Windows + clang (Closed)

Created:
4 years, 4 months ago by jungshik at Google
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Use -Wno-unused-const-variable only on Windows + clang BUG=626078 TEST=trybot succeeds on non-Windows. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/b71982a946ec7b88fb64078e8b492a5ce0e0c656

Patch Set 1 #

Patch Set 2 : add back no-unused-function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M BUILD.gn View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jungshik at Google
PTAL. Thanks
4 years, 4 months ago (2016-08-06 00:06:25 UTC) #2
Robert Sesek
LGTM thanks!
4 years, 4 months ago (2016-08-08 17:51:18 UTC) #3
jungshik at Google
4 years, 4 months ago (2016-08-08 20:26:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b71982a946ec7b88fb64078e8b492a5ce0e0c656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698