Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: BUILD.gn

Issue 2218673002: Use -Wno-unused-const-variable only on Windows + clang (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: add back no-unused-function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/rules.gni") 8 import("//build/config/android/rules.gni")
9 } 9 }
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 "-Wno-tautological-compare", 94 "-Wno-tautological-compare",
95 # uresdata.c has switch(RES_GET_TYPE(x)) code. The 95 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
96 # RES_GET_TYPE macro returns an UResType enum, but some switch 96 # RES_GET_TYPE macro returns an UResType enum, but some switch
97 # statement contains case values that aren't part of that 97 # statement contains case values that aren't part of that
98 # enum (e.g. URES_TABLE32 which is in UResInternalType). This 98 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
99 # is on purpose. 99 # is on purpose.
100 "-Wno-switch", 100 "-Wno-switch",
101 # ICU has some code with the pattern: 101 # ICU has some code with the pattern:
102 # if (found = uprv_getWindowsTimeZoneInfo(...)) 102 # if (found = uprv_getWindowsTimeZoneInfo(...))
103 "-Wno-parentheses", 103 "-Wno-parentheses",
104 # ICU generally has no unused variables, but there are a few places where
105 # this warning triggers.
106 # See https://codereview.chromium.org/1222643002/ and
107 # http://www.icu-project.org/trac/ticket/11759.
108 "-Wno-unused-const-variable",
109 # ucnv2022.cpp contains three functions that are only used when 104 # ucnv2022.cpp contains three functions that are only used when
110 # certain preprocessor defines are set. 105 # certain preprocessor defines are set.
106 # unistr.cpp also has an unused function for non-component builds.
111 "-Wno-unused-function", 107 "-Wno-unused-function",
112 ] 108 ]
113 if (is_win) { 109 if (is_win) {
114 cflags += [ 110 cflags += [
115 # See http://bugs.icu-project.org/trac/ticket/11122 111 # See http://bugs.icu-project.org/trac/ticket/11122
116 "-Wno-inline-new-delete", 112 "-Wno-inline-new-delete",
117 "-Wno-implicit-exception-spec-mismatch", 113 "-Wno-implicit-exception-spec-mismatch",
114 # See http://www.icu-project.org/trac/ticket/11759.
115 "-Wno-unused-const-variable",
118 ] 116 ]
119 } 117 }
120 } 118 }
121 } 119 }
122 120
123 component("icui18n") { 121 component("icui18n") {
124 # find source/i18n -maxdepth 1 ! -type d | egrep '\.(c|cpp|h)$' |\ 122 # find source/i18n -maxdepth 1 ! -type d | egrep '\.(c|cpp|h)$' |\
125 # sort | sed 's/^\(.*\)$/ "\1",/' 123 # sort | sed 's/^\(.*\)$/ "\1",/'
126 sources = [ 124 sources = [
127 "source/i18n/affixpatternparser.cpp", 125 "source/i18n/affixpatternparser.cpp",
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
1041 } 1039 }
1042 } 1040 }
1043 1041
1044 source_set("icudata") { 1042 source_set("icudata") {
1045 sources = [ "$data_assembly" ] 1043 sources = [ "$data_assembly" ]
1046 defines = [ "U_HIDE_DATA_SYMBOL" ] 1044 defines = [ "U_HIDE_DATA_SYMBOL" ]
1047 deps = [ ":make_data_assembly", ] 1045 deps = [ ":make_data_assembly", ]
1048 } 1046 }
1049 } 1047 }
1050 } 1048 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698