Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: BUILD.gn

Issue 2218673002: Use -Wno-unused-const-variable only on Windows + clang (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: add back no-unused-function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8741f6d62d47275e3455f6d72710e4d0ed69477a..3032b5079a5c8a3421ef7151de08300e5303f7ea 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -101,13 +101,9 @@ config("icu_code") {
# ICU has some code with the pattern:
# if (found = uprv_getWindowsTimeZoneInfo(...))
"-Wno-parentheses",
- # ICU generally has no unused variables, but there are a few places where
- # this warning triggers.
- # See https://codereview.chromium.org/1222643002/ and
- # http://www.icu-project.org/trac/ticket/11759.
- "-Wno-unused-const-variable",
# ucnv2022.cpp contains three functions that are only used when
# certain preprocessor defines are set.
+ # unistr.cpp also has an unused function for non-component builds.
"-Wno-unused-function",
]
if (is_win) {
@@ -115,6 +111,8 @@ config("icu_code") {
# See http://bugs.icu-project.org/trac/ticket/11122
"-Wno-inline-new-delete",
"-Wno-implicit-exception-spec-mismatch",
+ # See http://www.icu-project.org/trac/ticket/11759.
+ "-Wno-unused-const-variable",
]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698