Accessibility strings for app install alerts

Accessibility strings for app install alerts

Adds accessibility strings to touch exploration, and fixes the "open" button coloring on the Nexus S (weird shape defaults on ICS).

BUG=356309, 353672
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261548

[gone, 2014-04-02 18:03:02]

Strings are still being finalized, but if you could look at it functionally,
that'd be great. Thanks!

[newt (away), 2014-04-02 18:48:39]

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:438:
String accessibilityText = null;
why create this variable, if it's only set in one place?

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/strings/android_chrome_strings.grd:298: Prompt to get app
from the Google Play Store: <ph name="APP_NAME">^1<ex>Gmail</ex></ph>.  App
average rating: <ph name="APP_RATING">^2<ex>0.0</ex></ph>.
How about just using String.format() format specifiers here?

e.g. ^1 -> %1$s and ^2 -> %2$.1f

then you can simplify AppBannerView.setAccessibilityInformation()

[David Trainor- moved to gerrit, 2014-04-02 19:48:53]

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:263:
String bannerTemplate =
getContext().getString(R.string.app_banner_view_accessibility);
I think you can put arguments inline in the getString function. 
getString(R.string.app_banner_view_accessibility, appTitle, ratingString) might
work?

[gone, 2014-04-02 22:18:26]

Also fixed the open button color in this one by flipping the ordering of the
open button attributes.

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:263:
String bannerTemplate =
getContext().getString(R.string.app_banner_view_accessibility);
On 2014/04/02 19:48:54, David Trainor wrote:
> I think you can put arguments inline in the getString function. 
> getString(R.string.app_banner_view_accessibility, appTitle, ratingString)
might
> work?

Redid this a bit.

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:438:
String accessibilityText = null;
On 2014/04/02 18:48:40, newt wrote:
> why create this variable, if it's only set in one place?

Because Rome was built like pancakes.

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/strings/android_chrome_strings.grd:298: Prompt to get app
from the Google Play Store: <ph name="APP_NAME">^1<ex>Gmail</ex></ph>.  App
average rating: <ph name="APP_RATING">^2<ex>0.0</ex></ph>.
On 2014/04/02 18:48:40, newt wrote:
> How about just using String.format() format specifiers here?
> 
> e.g. ^1 -> %1$s and ^2 -> %2$.1f
> 
> then you can simplify AppBannerView.setAccessibilityInformation()

Done.

[newt (away), 2014-04-02 22:51:19]

lgtm with some important suggestions

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:438:
String accessibilityText = null;
On 2014/04/02 22:18:26, dfalcantara wrote:
> On 2014/04/02 18:48:40, newt wrote:
> > why create this variable, if it's only set in one place?
> 
> Because Rome was built like pancakes.

Rome is the messiest city. The Egyptians invented geometry, not the Romans. Go
figure.

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:260:
String bannerTemplate =
getContext().getString(R.string.app_banner_view_accessibility);
even simpler:

    String bannerText =
getResources().getString(R.string.app_banner_view_accessibility,
            mAppData.title(), mAppData.rating());

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:298: Prompt to get app
from the Google Play Store: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App
average rating: <ph name="APP_RATING">%2$.1f<ex>0.0</ex></ph>.
0.0?? How about 100.100?! Or maybe 4.2

[gone, 2014-04-02 23:13:12]

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:438:
String accessibilityText = null;
On 2014/04/02 22:51:20, newt wrote:
> On 2014/04/02 22:18:26, dfalcantara wrote:
> > On 2014/04/02 18:48:40, newt wrote:
> > > why create this variable, if it's only set in one place?
> > 
> > Because Rome was built like pancakes.
> 
> Rome is the messiest city. The Egyptians invented geometry, not the Romans. Go
> figure.

Perhaps, but Romans did build aqueducts, which made running water accessible.

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
(right):

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java:260:
String bannerTemplate =
getContext().getString(R.string.app_banner_view_accessibility);
On 2014/04/02 22:51:20, newt wrote:
> even simpler:
> 
>     String bannerText =
> getResources().getString(R.string.app_banner_view_accessibility,
>             mAppData.title(), mAppData.rating());

Done.

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/221823005/diff/20001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:298: Prompt to get app
from the Google Play Store: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App
average rating: <ph name="APP_RATING">%2$.1f<ex>0.0</ex></ph>.
On 2014/04/02 22:51:20, newt wrote:
> 0.0?? How about 100.100?! Or maybe 4.2

Would've gone over 9000, but I wanted it to be realistic.  Went with 4.2.

[David Trainor- moved to gerrit, 2014-04-03 17:32:53]

lgtm

[gone, 2014-04-03 17:33:21]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-04-03 17:33:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/221823005/40001

[gone, 2014-04-03 18:23:42]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-04-03 22:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 22:19:46]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[gone, 2014-04-03 22:20:16]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2014-04-03 22:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/221823005/40001

[commit-bot: I haz the power, 2014-04-03 22:23:15]

Change committed as 261548