chrome/android/java/res/layout/app_banner_view.xml - Issue 221823005: Accessibility strings for app install alerts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/app_banner_view.xml

Issue 221823005: Accessibility strings for app install alerts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Redid string, implemented suggestions Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/app_banner_view.xml

diff --git a/chrome/android/java/res/layout/app_banner_view.xml b/chrome/android/java/res/layout/app_banner_view.xml

index 95928dec2c026806f1527e7934fd07fb5d8b9286..267fd2367dda32959028907b722f8323c24fa4cd 100644

--- a/chrome/android/java/res/layout/app_banner_view.xml

+++ b/chrome/android/java/res/layout/app_banner_view.xml

@@ -8,6 +8,8 @@

xmlns:android="http://schemas.android.com/apk/res/android"

android:id="@+id/app_banner_view"

android:background="@drawable/card_background_default"

+ android:clickable="true"

+ android:focusableInTouchMode="true"

android:layout_width="match_parent"

android:layout_height="wrap_content">

@@ -66,6 +68,7 @@

<ImageButton

android:id="@+id/close_button"

+ android:contentDescription="@string/infobar_close"

android:adjustViewBounds="true"

android:src="@drawable/dismiss"

android:background="@drawable/app_banner_button_close"