Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2244)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java

Issue 221823005: Accessibility strings for app install alerts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Redid string, implemented suggestions Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
index 9345693824256146903a5939f53024940756e817..e5f7fde9a514f6d2d473b35956b69ba082e1c327 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
@@ -242,6 +242,7 @@ public class AppBannerView extends SwipableOverlayView
mTitleView.setText(mAppData.title());
mIconView.setImageDrawable(mAppData.icon());
mRatingView.initialize(mAppData.rating());
+ setAccessibilityInformation();
// Determine how much the user can drag sideways before their touch is considered a scroll.
mTouchSlop = ViewConfiguration.get(getContext()).getScaledTouchSlop();
@@ -250,6 +251,15 @@ public class AppBannerView extends SwipableOverlayView
updateButtonAppearance();
}
+ /**
+ * Creates a succinct description about the app being advertised.
+ */
+ private void setAccessibilityInformation() {
+ String bannerText = getContext().getString(
+ R.string.app_banner_view_accessibility, mAppData.title(), mAppData.rating());
+ setContentDescription(bannerText);
+ }
+
@Override
public void onClick(View view) {
if (mObserver == null) return;
@@ -431,6 +441,8 @@ public class AppBannerView extends SwipableOverlayView
fgColor = res.getColor(R.color.app_banner_install_button_fg);
if (mInstallState == INSTALL_STATE_NOT_INSTALLED) {
text = mAppData.installButtonText();
+ mInstallButtonView.setContentDescription(
+ getContext().getString(R.string.app_banner_install_accessibility, text));
} else {
text = res.getString(R.string.app_banner_installing);
}
« no previous file with comments | « chrome/android/java/res/layout/app_banner_view.xml ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698