Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2217483003: Remove untracked histograms: Net.QuicSession.TruncatedAcksReceived/TruncatedAcksSent (Closed)

Created:
4 years, 4 months ago by Zhongyi Shi
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove untracked histograms: Net.QuicSession.TruncatedAcksReceived/TruncatedAcksSent BUG=603636 Committed: https://crrev.com/d74c52f2081fd4df2adb6548fe785473fccc39e0 Cr-Commit-Position: refs/heads/master@{#410006}

Patch Set 1 #

Patch Set 2 : Fully remove the truncated acks counting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -124 lines) Patch
M net/net.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_connection_logger.h View 1 3 chunks +0 lines, -10 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.cc View 1 4 chunks +0 lines, -32 lines 0 comments Download
D net/quic/chromium/quic_connection_logger_unittest.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Zhongyi Shi
4 years, 4 months ago (2016-08-04 19:11:52 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 4 months ago (2016-08-04 19:13:14 UTC) #4
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-04 22:51:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217483003/1
4 years, 4 months ago (2016-08-04 22:56:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/107375) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-04 23:08:19 UTC) #9
Zhongyi Shi
Turned out the logging code wasn't removed cleanly. Ryan: can you re-approve?
4 years, 4 months ago (2016-08-05 00:00:40 UTC) #12
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-05 00:06:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217483003/20001
4 years, 4 months ago (2016-08-05 06:55:16 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 06:58:56 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 07:00:28 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d74c52f2081fd4df2adb6548fe785473fccc39e0
Cr-Commit-Position: refs/heads/master@{#410006}

Powered by Google App Engine
This is Rietveld 408576698