Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: net/quic/chromium/quic_connection_logger_unittest.cc

Issue 2217483003: Remove untracked histograms: Net.QuicSession.TruncatedAcksReceived/TruncatedAcksSent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fully remove the truncated acks counting Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_connection_logger.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/quic/chromium/quic_connection_logger.h"
6
7 #include "net/cert/x509_certificate.h"
8 #include "net/quic/test_tools/quic_connection_peer.h"
9 #include "net/quic/test_tools/quic_test_utils.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11
12 namespace net {
13 namespace test {
14
15 class QuicConnectionLoggerPeer {
16 public:
17 static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) {
18 return logger.num_truncated_acks_sent_;
19 }
20
21 static void set_num_packets_received(QuicConnectionLogger* logger,
22 int value) {
23 logger->num_packets_received_ = value;
24 }
25
26 static void set_largest_received_packet_number(QuicConnectionLogger* logger,
27 int value) {
28 logger->largest_received_packet_number_ = value;
29 }
30 };
31
32 class QuicConnectionLoggerTest : public ::testing::Test {
33 protected:
34 QuicConnectionLoggerTest()
35 : session_(new MockQuicConnection(&helper_,
36 &alarm_factory_,
37 Perspective::IS_CLIENT)),
38 logger_(&session_,
39 "CONNECTION_UNKNOWN",
40 /*socket_performance_watcher=*/nullptr,
41 net_log_) {
42 QuicConnectionPeer::GetFramer(session_.connection())
43 ->set_version(QUIC_VERSION_33);
44 }
45
46 BoundNetLog net_log_;
47 MockQuicConnectionHelper helper_;
48 MockAlarmFactory alarm_factory_;
49 MockQuicSpdySession session_;
50 QuicConnectionLogger logger_;
51 };
52
53 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) {
54 QuicAckFrame frame;
55 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
56 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
57
58 for (QuicPacketNumber i = 0; i < 256; ++i) {
59 frame.packets.Add(i);
60 }
61 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
62 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
63 }
64
65 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) {
66 QuicAckFrame frame;
67 for (QuicPacketNumber i = 0; i < 512; i += 2) {
68 frame.packets.Add(i);
69 }
70 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
71 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
72 }
73
74 TEST_F(QuicConnectionLoggerTest, ReceivedPacketLossRate) {
75 QuicConnectionLoggerPeer::set_num_packets_received(&logger_, 1);
76 QuicConnectionLoggerPeer::set_largest_received_packet_number(&logger_, 2);
77 EXPECT_EQ(0.5f, logger_.ReceivedPacketLossRate());
78 }
79
80 } // namespace test
81 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_connection_logger.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698