Remove untracked histograms: Net.QuicSession.TruncatedAcksReceived/TruncatedAcksSent

net/quic/chromium/quic_connection_logger.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/chromium/quic_connection_logger.h"
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <utility>
@@ skipping 282 matching lines @@
       session_(session),
       last_received_packet_number_(0),
       last_received_packet_size_(0),
       previous_received_packet_size_(0),
       last_packet_sent_time_(base::TimeTicks()),
       largest_received_packet_number_(0),
       largest_received_missing_packet_number_(0),
       num_out_of_order_received_packets_(0),
       num_out_of_order_large_received_packets_(0),
       num_packets_received_(0),
-      num_truncated_acks_sent_(0),
-      num_truncated_acks_received_(0),
       num_frames_received_(0),
       num_duplicate_frames_received_(0),
       num_incorrect_connection_ids_(0),
       num_undecryptable_packets_(0),
       num_duplicate_packets_(0),
       num_blocked_frames_received_(0),
       num_blocked_frames_sent_(0),
       connection_description_(connection_description),
       socket_performance_watcher_(std::move(socket_performance_watcher)) {}
 
 QuicConnectionLogger::~QuicConnectionLogger() {
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.OutOfOrderPacketsReceived",
                        num_out_of_order_received_packets_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.OutOfOrderLargePacketsReceived",
                        num_out_of_order_large_received_packets_);
-  UMA_HISTOGRAM_COUNTS("Net.QuicSession.TruncatedAcksSent",
-                       num_truncated_acks_sent_);
-  UMA_HISTOGRAM_COUNTS("Net.QuicSession.TruncatedAcksReceived",
-                       num_truncated_acks_received_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.IncorrectConnectionIDsReceived",
                        num_incorrect_connection_ids_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.UndecryptablePacketsReceived",
                        num_undecryptable_packets_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.DuplicatePacketsReceived",
                        num_duplicate_packets_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.BlockedFrames.Received",
                        num_blocked_frames_received_);
   UMA_HISTOGRAM_COUNTS("Net.QuicSession.BlockedFrames.Sent",
                        num_blocked_frames_sent_);
@@ skipping 23 matching lines @@
       break;
     case STREAM_FRAME:
       net_log_.AddEvent(
           NetLog::TYPE_QUIC_SESSION_STREAM_FRAME_SENT,
           base::Bind(&NetLogQuicStreamFrameCallback, frame.stream_frame));
       break;
     case ACK_FRAME: {
       net_log_.AddEvent(
           NetLog::TYPE_QUIC_SESSION_ACK_FRAME_SENT,
           base::Bind(&NetLogQuicAckFrameCallback, frame.ack_frame));
-      // Missing packets histogram only relevant for v33 and lower
-      // TODO(rch, rtenneti) sort out histograms for v34+
-      if (session_->connection()->version() > QUIC_VERSION_33) {
-        break;
-      }
-      const PacketNumberQueue& missing_packets = frame.ack_frame->packets;
-      const uint8_t max_ranges = std::numeric_limits<uint8_t>::max();
-      // Compute an upper bound on the number of NACK ranges. If the bound
-      // is below the max, then it clearly isn't truncated.
-      if (missing_packets.NumPacketsSlow() < max_ranges ||
-          (missing_packets.Max() - missing_packets.Min() -
-           missing_packets.NumPacketsSlow() + 1) < max_ranges) {
-        break;
-      }
-      size_t num_ranges = 0;
-      QuicPacketNumber last_missing = 0;
-      for (QuicPacketNumber packet : missing_packets) {
-        if (packet != last_missing + 1 && ++num_ranges >= max_ranges) {
-          ++num_truncated_acks_sent_;
-          break;
-        }
-        last_missing = packet;
-      }
       break;
     }
     case RST_STREAM_FRAME:
       UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.RstStreamErrorCodeClient",
                                   frame.rst_stream_frame->error_code);
       net_log_.AddEvent(NetLog::TYPE_QUIC_SESSION_RST_STREAM_FRAME_SENT,
                         base::Bind(&NetLogQuicRstStreamFrameCallback,
                                    frame.rst_stream_frame));
       break;
     case CONNECTION_CLOSE_FRAME:
@@ skipping 151 matching lines @@
 void QuicConnectionLogger::OnAckFrame(const QuicAckFrame& frame) {
   net_log_.AddEvent(NetLog::TYPE_QUIC_SESSION_ACK_FRAME_RECEIVED,
                     base::Bind(&NetLogQuicAckFrameCallback, &frame));
 
   const size_t kApproximateLargestSoloAckBytes = 100;
   if (last_received_packet_number_ < received_acks_.size() &&
       last_received_packet_size_ < kApproximateLargestSoloAckBytes) {
     received_acks_[static_cast<size_t>(last_received_packet_number_)] = true;
   }
 
-  if (frame.is_truncated)
-    ++num_truncated_acks_received_;
-
   if (frame.packets.Empty())
     return;
 
   // TODO(rch, rtenneti) sort out histograms for QUIC_VERSION_34 and above.
   if (session_->connection()->version() > QUIC_VERSION_33) {
     return;
   }
   const PacketNumberQueue& missing_packets = frame.packets;
   PacketNumberQueue::const_iterator it =
       missing_packets.lower_bound(largest_received_missing_packet_number_);
@@ skipping 313 matching lines @@
       continue;
     }
     // Record some overlapping patterns, to get a better picture, since this is
     // not very expensive.
     if (i % 3 == 0)
       six_packet_histogram->Add(recent_6_mask);
   }
 }
 
 }  // namespace net