Refactor fx_ge part 2

Move CFX_ClipRgn and CFX_PathData into their own files.

This is the second CL in an attempt to split up the classes in fxge/include/fx_ge.h into their own files. CFX_ClipRgn is moved to core/fxge/ge because it is only used in core/fxge. The header for CFX_PathData is left in core/fxge/include since it is used elsewhere.

Committed: https://pdfium.googlesource.com/pdfium/+/660de3c494b68a574cb4cdf20359f51ddc260d3c

[npm, 2016-08-05 19:13:23]

Description was changed from

==========
Refactor fx_ge part 2

BUG=
==========

to

==========
Move CFX_ClipRgn and CFX_PathData into their own files.

This is the second CL in an attempt to split up the classes in
fxge/include/fx_ge.h into their own files. CFX_ClipRgn is moved to core/fxge/ge
because it is only used in core/fxge. The header for CFX_PathData is left in
core/fxge/include since it is used elsewhere.
==========

[npm, 2016-08-05 19:13:24]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-05 19:13:42]

PTAL

[Lei Zhang, 2016-08-06 00:14:34]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 00:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:21:36]

Dry run: Try jobs failed on following builders:
  mac_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa_rel_gyp...)

[Lei Zhang, 2016-08-06 00:29:42]

It would be good to do a CQ dry run, especially when it's a cross-platform
change.

Also prefer to wrap the CL description, AKA the git commit message, at 72
columns.

https://codereview.chromium.org/2216853004/diff/1/core/fpdfapi/fpdf_page/page...
File core/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fpdfapi/fpdf_page/page...
core/fpdfapi/fpdf_page/pageint.h:19: 
extra blank line?

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cpp
File core/fxge/ge/cfx_cliprgn.cpp (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:1: // Copyright 2014 PDFium Authors. All rights
reserved.
Also 2016

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h
File core/fxge/ge/cfx_cliprgn.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:10: #include <memory>
Not needed

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:19: explicit CFX_ClipRgn(const FX_RECT& rect);
BTW, possibly not used.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/fx_ge_path.cpp
File core/fxge/ge/fx_ge_path.cpp (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/fx_ge_path.cpp...
core/fxge/ge/fx_ge_path.cpp:9: #include "third_party/base/numerics/safe_math.h"
No longer needed?

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
File core/fxge/include/cfx_pathdata.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:10: #include <memory>
Not needed?

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:12: #include "core/fxge/include/fx_font.h"
Probably want fx_system.h and possibly others. I don't see "font" anywhere else
in the file.

[dsinclair, 2016-08-08 13:59:47]

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cpp
File core/fxge/ge/cfx_cliprgn.cpp (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:57: }
nit: no {}'s

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:91: return;
ditto

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h
File core/fxge/ge/cfx_cliprgn.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:31: protected:
Can this be private? Are there any subclasses of CFX_ClipRgn?

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
File core/fxge/include/cfx_pathdata.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:50: protected:
private?

[npm, 2016-08-08 14:55:53]

TALP

https://codereview.chromium.org/2216853004/diff/1/core/fpdfapi/fpdf_page/page...
File core/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fpdfapi/fpdf_page/page...
core/fpdfapi/fpdf_page/pageint.h:19: 
On 2016/08/06 00:29:41, Lei Zhang wrote:
> extra blank line?

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cpp
File core/fxge/ge/cfx_cliprgn.cpp (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:1: // Copyright 2014 PDFium Authors. All rights
reserved.
On 2016/08/06 00:29:41, Lei Zhang wrote:
> Also 2016

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:57: }
On 2016/08/08 13:59:46, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.cp...
core/fxge/ge/cfx_cliprgn.cpp:91: return;
On 2016/08/08 13:59:46, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h
File core/fxge/ge/cfx_cliprgn.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:10: #include <memory>
On 2016/08/06 00:29:41, Lei Zhang wrote:
> Not needed

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:19: explicit CFX_ClipRgn(const FX_RECT& rect);
On 2016/08/06 00:29:42, Lei Zhang wrote:
> BTW, possibly not used.

It does look like this is not currently being used.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/cfx_cliprgn.h#...
core/fxge/ge/cfx_cliprgn.h:31: protected:
On 2016/08/08 13:59:46, dsinclair wrote:
> Can this be private? Are there any subclasses of CFX_ClipRgn?

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/fx_ge_path.cpp
File core/fxge/ge/fx_ge_path.cpp (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/ge/fx_ge_path.cpp...
core/fxge/ge/fx_ge_path.cpp:9: #include "third_party/base/numerics/safe_math.h"
On 2016/08/06 00:29:42, Lei Zhang wrote:
> No longer needed?

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
File core/fxge/include/cfx_pathdata.h (right):

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:10: #include <memory>
On 2016/08/06 00:29:42, Lei Zhang wrote:
> Not needed?

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:12: #include "core/fxge/include/fx_font.h"
On 2016/08/06 00:29:42, Lei Zhang wrote:
> Probably want fx_system.h and possibly others. I don't see "font" anywhere
else
> in the file.

Done.

https://codereview.chromium.org/2216853004/diff/1/core/fxge/include/cfx_pathd...
core/fxge/include/cfx_pathdata.h:50: protected:
On 2016/08/08 13:59:47, dsinclair wrote:
> private?

Done.

[npm, 2016-08-08 14:57:01]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:57:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 15:11:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 15:11:01]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-08 15:17:58]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-08 15:17:59]

lgtm

[commit-bot: I haz the power, 2016-08-08 15:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 15:18:33]

Description was changed from

==========
Move CFX_ClipRgn and CFX_PathData into their own files.

This is the second CL in an attempt to split up the classes in
fxge/include/fx_ge.h into their own files. CFX_ClipRgn is moved to core/fxge/ge
because it is only used in core/fxge. The header for CFX_PathData is left in
core/fxge/include since it is used elsewhere.
==========

to

==========
Move CFX_ClipRgn and CFX_PathData into their own files.

This is the second CL in an attempt to split up the classes in
fxge/include/fx_ge.h into their own files. CFX_ClipRgn is moved to core/fxge/ge
because it is only used in core/fxge. The header for CFX_PathData is left in
core/fxge/include since it is used elsewhere.

Committed:
https://pdfium.googlesource.com/pdfium/+/660de3c494b68a574cb4cdf20359f51ddc26...
==========

[commit-bot: I haz the power, 2016-08-08 15:18:35]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/660de3c494b68a574cb4cdf20359f51ddc26...