Use warning instead of error in a couple places. In polymer we are hitting

Use warning instead of error in a couple places. In polymer we are hitting
scenarios where the resolution was incorrect, but we were still able to generate
valid code. We should not stop the whole build process on these cases.
(see for example https://code.google.com/p/dart/issues/detail?id=17914).

R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34656

[Siggi Cherem (dart-lang), 2014-04-02 02:56:32]

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
File pkg/code_transformers/lib/assets.dart (right):

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
pkg/code_transformers/lib/assets.dart:34: logger.error('absolute paths not
allowed: "$url"', span: span);
should we turn this into a warning too? If so, should we change the argument
name to warningOnAbsolute?

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/pubspe...
File pkg/code_transformers/pubspec.yaml (right):

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/pubspe...
pkg/code_transformers/pubspec.yaml:2: version: 0.1.1+1
I hope to upload immediately after submitting

[blois, 2014-04-02 14:58:33]

lgtm. I should have done this when moving the code from polymer- I really
dislike pub's handling of errors and believe that errors and exceptions should
be avoided except for very extreme cases.

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
File pkg/code_transformers/lib/assets.dart (right):

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
pkg/code_transformers/lib/assets.dart:34: logger.error('absolute paths not
allowed: "$url"', span: span);
On 2014/04/02 02:56:33, Siggi Cherem (dart-lang) wrote:
> should we turn this into a warning too? If so, should we change the argument
> name to warningOnAbsolute?

Should probably change it to be a warning, would be nice not to change the name.

[Siggi Cherem (dart-lang), 2014-04-02 16:31:55]

Thanks Pete

PTAL - I made the last error into a warning without changing the parameter name,
but I tried to include more dart-docs to explain the internal behavior.

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
File pkg/code_transformers/lib/assets.dart (right):

https://codereview.chromium.org/221673005/diff/1/pkg/code_transformers/lib/as...
pkg/code_transformers/lib/assets.dart:34: logger.error('absolute paths not
allowed: "$url"', span: span);
On 2014/04/02 14:58:34, blois wrote:
> On 2014/04/02 02:56:33, Siggi Cherem (dart-lang) wrote:
> > should we turn this into a warning too? If so, should we change the argument
> > name to warningOnAbsolute?
> 
> Should probably change it to be a warning, would be nice not to change the
name.

Done.

[blois, 2014-04-02 17:18:21]

lgtm

[Siggi Cherem (dart-lang), 2014-04-02 17:57:42]

Committed patchset #2 manually as r34656 (presubmit successful).