Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: pkg/code_transformers/test/resolver_test.dart

Issue 221673005: Use warning instead of error in a couple places. In polymer we are hitting (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/code_transformers/test/assets_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_transformers.test.resolver_test; 5 library code_transformers.test.resolver_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:barback/barback.dart'; 9 import 'package:barback/barback.dart';
10 import 'package:code_transformers/resolver.dart'; 10 import 'package:code_transformers/resolver.dart';
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 main() { 163 main() {
164 } ''', 164 } ''',
165 }, 165 },
166 validator: (resolver) { 166 validator: (resolver) {
167 var lib = resolver.getLibrary(entryPoint); 167 var lib = resolver.getLibrary(entryPoint);
168 expect(lib.importedLibraries.length, 1); 168 expect(lib.importedLibraries.length, 1);
169 }); 169 });
170 }); 170 });
171 171
172 test('should fail on absolute URIs', () { 172 test('should fail on absolute URIs', () {
173 var warningPrefix = 'warning: absolute paths not allowed';
173 return validateResolver( 174 return validateResolver(
174 inputs: { 175 inputs: {
175 'a|web/main.dart': ''' 176 'a|web/main.dart': '''
176 import '/b.dart'; 177 import '/b.dart';
177 178
178 main() { 179 main() {
179 } ''', 180 } ''',
180 }, 181 },
181 messages: [ 182 messages: [
182 // First from the AST walker 183 // First from the AST walker
183 'error: absolute paths not allowed: "/b.dart" (web/main.dart 0 14)', 184 '$warningPrefix: "/b.dart" (web/main.dart 0 14)',
184 'error: absolute paths not allowed: "/b.dart"', 185 '$warningPrefix: "/b.dart"',
185 ], 186 ],
186 validator: (resolver) { 187 validator: (resolver) {
187 var lib = resolver.getLibrary(entryPoint); 188 var lib = resolver.getLibrary(entryPoint);
188 expect(lib.importedLibraries.length, 1); 189 expect(lib.importedLibraries.length, 1);
189 }); 190 });
190 }); 191 });
191 192
192 test('should list all libraries', () { 193 test('should list all libraries', () {
193 return validateResolver( 194 return validateResolver(
194 inputs: { 195 inputs: {
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 352
352 TestTransformer(Resolvers resolvers, this.primary, this.validator) { 353 TestTransformer(Resolvers resolvers, this.primary, this.validator) {
353 this.resolvers = resolvers; 354 this.resolvers = resolvers;
354 } 355 }
355 356
356 Future<bool> isPrimary(Asset input) => 357 Future<bool> isPrimary(Asset input) =>
357 new Future.value(input.id == primary); 358 new Future.value(input.id == primary);
358 359
359 applyResolver(Transform transform, Resolver resolver) => validator(resolver); 360 applyResolver(Transform transform, Resolver resolver) => validator(resolver);
360 } 361 }
OLDNEW
« no previous file with comments | « pkg/code_transformers/test/assets_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698