third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp - Issue 2216593002: Drop document.createEvent support for things still behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

Issue 2216593002: Drop document.createEvent support for things still behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@createEvent

Patch Set: fix LayoutTests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp ('k') | third_party/WebKit/Source/modules/sensor/SensorErrorEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

index 5f883aa30f5b0e12296eb2adb418ad28d6e2c9ae..fdaa7f8ee3f7586bb88aa4d3a32e32be1d93f46c 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

@@ -36,7 +36,7 @@ public:

TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsCalled)

{

V8TestingScope scope;

- PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create();

+ PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(EventTypeNames::shippingaddresschange);

MockPaymentUpdater* updater = new MockPaymentUpdater;

event->setPaymentDetailsUpdater(updater);

event->setEventPhase(Event::kCapturingPhase);

@@ -109,7 +109,7 @@ TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsTimeout)

PaymentRequestMockFunctionScope funcs(scope.getScriptState());

makePaymentRequestOriginSecure(scope.document());

PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), scope.getExceptionState());

- PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create();

+ PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(EventTypeNames::shippingaddresschange);

event->setPaymentDetailsUpdater(request);

EXPECT_FALSE(scope.getExceptionState().hadException());