Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by Michael Achenbach Modified:
4 years, 4 months ago Reviewers:
Jakob Kummerow, tandrii(chromium) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Fix merging of test outcomes
BUG=v8:5238
Committed: https://crrev.com/11d0d16ea93cfae2a86b5beb4a74fdf8e3c8bd4d
Cr-Commit-Position: refs/heads/master@{#38362}
Patch Set 1 #
Total comments: 1
Created: 4 years, 4 months ago
Messages
Total messages: 16 (9 generated)
Description was changed from ========== [test] Fix merging of test outcomes BUG= ========== to ========== [test] Fix merging of test outcomes BUG=v8:5238 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, tandrii@chromium.org
PTAL. This stems from |= mutating the left hand object here: https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/testsuite.py?q... We could also defensively use everywhere: a = a | b And also make all sets frozensets. Not sure if that could have a performance impact.
https://codereview.chromium.org/2216293002/diff/1/tools/testrunner/local/test... File tools/testrunner/local/testsuite_unittest.py (right): https://codereview.chromium.org/2216293002/diff/1/tools/testrunner/local/test... tools/testrunner/local/testsuite_unittest.py:54: suite.tests = [ Btw: This test change reveals the problem.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Fix merging of test outcomes BUG=v8:5238 ========== to ========== [test] Fix merging of test outcomes BUG=v8:5238 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [test] Fix merging of test outcomes BUG=v8:5238 ========== to ========== [test] Fix merging of test outcomes BUG=v8:5238 Committed: https://crrev.com/11d0d16ea93cfae2a86b5beb4a74fdf8e3c8bd4d Cr-Commit-Position: refs/heads/master@{#38362} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/11d0d16ea93cfae2a86b5beb4a74fdf8e3c8bd4d Cr-Commit-Position: refs/heads/master@{#38362} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
