Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2216293002: [test] Fix merging of test outcomes (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix merging of test outcomes BUG=v8:5238 Committed: https://crrev.com/11d0d16ea93cfae2a86b5beb4a74fdf8e3c8bd4d Cr-Commit-Position: refs/heads/master@{#38362}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tools/testrunner/local/testsuite_unittest.py View 1 chunk +12 lines, -10 lines 1 comment Download
M tools/testrunner/objects/testcase.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael Achenbach
PTAL. This stems from |= mutating the left hand object here: https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/testsuite.py?q=testsuite.p&sq=package:chromium&l=182 We could also ...
4 years, 4 months ago (2016-08-05 09:02:06 UTC) #5
Michael Achenbach
https://codereview.chromium.org/2216293002/diff/1/tools/testrunner/local/testsuite_unittest.py File tools/testrunner/local/testsuite_unittest.py (right): https://codereview.chromium.org/2216293002/diff/1/tools/testrunner/local/testsuite_unittest.py#newcode54 tools/testrunner/local/testsuite_unittest.py:54: suite.tests = [ Btw: This test change reveals the ...
4 years, 4 months ago (2016-08-05 09:02:41 UTC) #6
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-05 09:33:45 UTC) #9
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-08-05 09:36:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216293002/1
4 years, 4 months ago (2016-08-05 09:38:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 09:40:24 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 09:43:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d0d16ea93cfae2a86b5beb4a74fdf8e3c8bd4d
Cr-Commit-Position: refs/heads/master@{#38362}

Powered by Google App Engine
This is Rietveld 408576698