Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/testrunner/local/testsuite_unittest.py

Issue 2216293002: [test] Fix merging of test outcomes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testrunner/objects/testcase.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/testsuite_unittest.py
diff --git a/tools/testrunner/local/testsuite_unittest.py b/tools/testrunner/local/testsuite_unittest.py
index 003822afdf36a50ee984d2ff830c93d3db468566..1e10ef5564e375560e4f3496c564b9e4a2e78902 100755
--- a/tools/testrunner/local/testsuite_unittest.py
+++ b/tools/testrunner/local/testsuite_unittest.py
@@ -43,18 +43,20 @@ class TestSuiteTest(unittest.TestCase):
def test_filter_testcases_by_status_second_pass(self):
suite = TestSuite('foo', 'bar')
- suite.tests = [
- TestCase(suite, 'foo/bar', variant='default'),
- TestCase(suite, 'foo/bar', variant='stress', flags=['-v']),
- TestCase(suite, 'baz/bar', variant='default'),
- TestCase(suite, 'baz/bar', variant='stress', flags=['-v']),
- ]
+
+ test1 = TestCase(suite, 'foo/bar')
+ test2 = TestCase(suite, 'baz/bar')
# Contrived outcomes from filtering by variant-independent rules.
- suite.tests[0].outcomes = set(['PREV'])
- suite.tests[1].outcomes = set(['PREV'])
- suite.tests[2].outcomes = set(['PREV'])
- suite.tests[3].outcomes = set(['PREV'])
+ test1.outcomes = set(['PREV'])
+ test2.outcomes = set(['PREV'])
+
+ suite.tests = [
Michael Achenbach 2016/08/05 09:02:41 Btw: This test change reveals the problem.
+ test1.CopyAddingFlags(variant='default', flags=[]),
+ test1.CopyAddingFlags(variant='stress', flags=['-v']),
+ test2.CopyAddingFlags(variant='default', flags=[]),
+ test2.CopyAddingFlags(variant='stress', flags=['-v']),
+ ]
suite.rules = {
'default': {
« no previous file with comments | « no previous file | tools/testrunner/objects/testcase.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698